Pubsub snippet fixups#1765
Merged
tseaver merged 4 commits intogoogleapis:masterfrom Apr 28, 2016
tseaver:1756-pubsub-snippet_fixup
Merged
Pubsub snippet fixups#1765tseaver merged 4 commits intogoogleapis:masterfrom tseaver:1756-pubsub-snippet_fixup
tseaver merged 4 commits intogoogleapis:masterfrom
tseaver:1756-pubsub-snippet_fixup
Conversation
tseaver
added
type: bug
googlebot
added
the
cla: yes
Contributor
Author
|
@dhermes PTAL |
|
|
||
| # [START subscription_pull_none_pending] | ||
| pulled = subscription.pull(max_messages=1) | ||
| # [END subscription_pull_none_pending] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Addresses: #1765 (comment).
Contributor
Author
Merged
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
feat: Add system test for cross-region buckets
- Adds a new system test, test_basic_wrd_x_region, to verify
functionality with cross-region GCS buckets.
- Also updates the Cloud Build configuration to pass the necessary
_CROSS_REGION_BUCKET environment variable to the test environment
This PR is a cherry-picked from
googleapis/python-storage#1760 because that PR
is blocked by b/489420625
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to #1756.
Tweaking pubsub snippets to ensure that running them actually passes:
time.sleep(1)between the lasttopic.publishcall and thesubscription.pull.Also, fixes a bug exposed by running the snippets: the API object's
subscription_pullmethod was not tolerant of an empty response.