Skip to content

Documentation: Filtering Query by key is also possible.#1632

Merged
dhermes merged 2 commits intogoogleapis:masterfrom
mgilson:patch-2
Mar 18, 2016
Merged

Documentation: Filtering Query by key is also possible.#1632
dhermes merged 2 commits intogoogleapis:masterfrom
mgilson:patch-2

Conversation

@mgilson
Copy link
Contributor

@mgilson mgilson commented Mar 18, 2016

Update the documentation for add_filter to make it clear that filtering by key is also possible.

Update the documentation for `add_filter` to make it clear that filtering by key is also possible.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2016
Fixup for lint.
@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2016

LGTM

dhermes added a commit that referenced this pull request Mar 18, 2016
Documentation: Filtering Query by key is also possible.
@dhermes dhermes merged commit 49f18ed into googleapis:master Mar 18, 2016
@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2016

Thanks @mgilson. In the future, if possible, can you squash your changes into a single commit? I'd be happy to help show you how if the need arises (e.g. here the lint error caused you to have to add a newline).

@mgilson
Copy link
Contributor Author

mgilson commented Mar 18, 2016

@dhermes Sure. Sorry about that. I would have squashed it on this one, but I was doing all of my edits via the github editor and didn't realize the error until travis yelled at me. I wanted to make sure travis was happy with the second commit before I rebased and force-pushed -- But by the time I got back, you had already merged.

@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2016

No worries. I didn't want to burden you with having a checkout. I appreciate the quick fix!

@tseaver tseaver added the api: datastore Issues related to the Datastore API. label Mar 18, 2016
parthea added a commit that referenced this pull request Mar 6, 2026
* build: [autoapprove] bump cryptography from 41.0.2 to 41.0.3

Source-Link: googleapis/synthtool@352b9d4
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7

* pin flake8

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants