Skip to content

Adding system tests for HappyBase Table.rows().#1605

Merged
dhermes merged 2 commits intogoogleapis:masterfrom
dhermes:sys-test-happybase-rows
Mar 14, 2016
Merged

Adding system tests for HappyBase Table.rows().#1605
dhermes merged 2 commits intogoogleapis:masterfrom
dhermes:sys-test-happybase-rows

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 12, 2016

No description provided.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Mar 12, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2016
table.put(ROW_KEY2, row2_data)

rows = table.rows([ROW_KEY1, ROW_KEY2])
rows.sort(key=_FIRST_ELT)

This comment was marked as spam.

This comment was marked as spam.

@tseaver
Copy link
Contributor

tseaver commented Mar 13, 2016

sorted() doesn't commit to having the source be an actual list. If that consideration is moot, then list.sort() is slightly more efficient (for big enough lists to make the cost of allocation measurable).

@dhermes
Copy link
Contributor Author

dhermes commented Mar 13, 2016

@tseaver PTAL

@dhermes
Copy link
Contributor Author

dhermes commented Mar 14, 2016

@tseaver Any issues here?

@tseaver
Copy link
Contributor

tseaver commented Mar 14, 2016

LGTM

dhermes added a commit that referenced this pull request Mar 14, 2016
Adding system tests for HappyBase Table.rows().
@dhermes dhermes merged commit fdae44a into googleapis:master Mar 14, 2016
@dhermes dhermes deleted the sys-test-happybase-rows branch March 14, 2016 17:52
parthea pushed a commit that referenced this pull request Mar 9, 2026
…rs that need to be url encoded (#1605)

fix(bucket): url encode new_name parameter in move_blob()

  The move_blob() method was not URL encoding the new_name parameter
  before passing it to the API call, unlike how the blob encodes its own
  path. This caused failures when moving blobs to paths with special
  characters.

  Added URL encoding for new_name to match the blob path encoding, as
both names must fit in the API URL format:
"{blob_path}/moveTo/o/{new_name}"

  Here's an example of what fails:
  ```python
  from google.cloud import storage
  gcs = storage.Client()
  bucket = gcs.bucket("")
  blob = bucket.get_blob("test/blob.csv")
  bucket.move_blob(
      blob, 
      new_name="test/blob2.csv"
  )
  ```

  Fixes #1523

---------

Co-authored-by: Chandra Shekhar Sirimala <chandrasiri@google.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
🤖 I have created a release *beep* *boop*
---


##
[3.7.0](googleapis/python-storage@v3.6.0...v3.7.0)
(2025-12-09)


### Features

* Auto enable mTLS when supported certificates are detected
([#1637](googleapis/python-storage#1637))
([4e91c54](googleapis/python-storage@4e91c54))
* Send entire object checksum in the final api call of resumable upload
([#1654](googleapis/python-storage#1654))
([ddce7e5](googleapis/python-storage@ddce7e5))
* Support urllib3 &gt;= 2.6.0
([#1658](googleapis/python-storage#1658))
([57405e9](googleapis/python-storage@57405e9))


### Bug Fixes

* **bucket:** Move blob fails when the new blob name contains characters
that need to be url encoded
([#1605](googleapis/python-storage#1605))
([ec470a2](googleapis/python-storage@ec470a2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Chandra Shekhar Sirimala <chandrasiri@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants