Moving Transaction tombstone behavior onto Batch.#1367
Merged
dhermes merged 2 commits intogoogleapis:masterfrom Jan 14, 2016
Merged
Moving Transaction tombstone behavior onto Batch.#1367dhermes merged 2 commits intogoogleapis:masterfrom
dhermes merged 2 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
|
We probably need to add explicit tests in |
Contributor
Author
|
👍 On it. |
This is so that commit request protos are not re-used, so we can re-use and modify them when passed into `Connection.commit`.
Contributor
Author
|
@tseaver PTAL |
Contributor
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jan 14, 2016
Moving Transaction tombstone behavior onto Batch.
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
…affolding (#1367) * chore(x-goog-spanner-request-id): plug in functionality after test scaffolding This change chops down the load of the large changes for x-goog-spanner-request-id. It depends on PR #1366 and should only be merged after that PR. Updates #1261 Requires PR #1366 * Include batch* * Address review feedback * chore: fix formatting --------- Co-authored-by: Knut Olav Løite <koloite@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so that commit request protos are not re-used, so we can re-use and modify them when passed into
Connection.commit.Fixes #1366.
@tseaver The tests still pass (as well as coverage) dude to transitive use of the newly moved code. What sort of tests would you like to see added?