Strip excess custom exceptions from 'gcloud.streaming'#1232
Merged
tseaver merged 7 commits intogoogleapis:masterfrom Nov 19, 2015
tseaver:1227-streaming-strip_excess_custom_exceptions
Merged
Strip excess custom exceptions from 'gcloud.streaming'#1232tseaver merged 7 commits intogoogleapis:masterfrom tseaver:1227-streaming-strip_excess_custom_exceptions
tseaver merged 7 commits intogoogleapis:masterfrom
tseaver:1227-streaming-strip_excess_custom_exceptions
Conversation
googlebot
added
the
cla: yes
gcloud/streaming/transfer.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
This doesn't "move the remainder to |
Contributor
Author
|
The residue are all tangled up with fixing #1223. If there are any left after that one, then they can move. |
Contributor
|
I suggest filing another bug then (or leaving that one open and renaming it) so it doesn't slip our minds. |
Contributor
Author
|
#1234 captures the final cleanup. |
Contributor
|
Good deal |
Allow 'natural' OSError to propagate. Addresses: #1232 (comment)
Contributor
|
LGTM pending Travis |
tseaver
added a commit
that referenced
this pull request
Nov 19, 2015
…tom_exceptions Strip excess custom exceptions from 'gcloud.streaming'
parthea
added a commit
that referenced
this pull request
Nov 22, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
🤖 I have created a release *beep* *boop* --- ### [0.63.7](googleapis/gapic-generator-python@v0.63.6...v0.63.7) (2022-03-08) ### Bug Fixes * resolve issue where rest transport is not used in certain tests ([#1231](googleapis/gapic-generator-python#1231)) ([90ab41a](googleapis/gapic-generator-python@90ab41a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
added a commit
that referenced
this pull request
Mar 2, 2026
parthea
added a commit
that referenced
this pull request
Mar 6, 2026
* chore: use gapic-generator-python 0.65.2 PiperOrigin-RevId: 444333013 Source-Link: googleapis/googleapis@f91b6cf Source-Link: googleapis/googleapis-gen@16eb360 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTZlYjM2MDk1YzI5NGU3MTJjNzRhMWJmMjM1NTA4MTdiNDIxNzRlNSJ9 * update owlbot.py to pull in changes from gapic generator Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1227