build(profiler): upgrade Kokoro CI configs and scripts to Node 22 - #9454
Merged
Merged
Conversation
product-auto-label
Bot
added
the
api: cloudprofiler
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Node.js environment to version 22 across Kokoro configurations and shell scripts, upgrades pnpm from version 9 to 10, and refines the installation and testing pipelines. It also updates integration tests to target Node 22 and 24, resolves unhandled promises using the void operator, and cleans up package scripts. The review feedback suggests double-quoting the $KOKORO_GFILE_DIR variable expansions in samples-test.sh and test.sh to prevent potential word splitting and globbing issues.
feywind
changed the title
shivanee-p
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the Kokoro CI configurations and scripts in
handwritten/cloud-profilerto Node 22 (gcr.io/cloud-devrel-kokoro-resources/node:22-user) andpnpm@10, resolving CI failures in:ci/kokoro: Samples test - handwritten/cloud-profilerci/kokoro: node14 - handwritten/cloud-profilerci/kokoro: node14 - nightly - handwritten/cloud-profilerci/kokoro: Samples test - nightly - handwritten/cloud-profilerSummary of Changes
node:22-user):.kokoro/common.cfgand.kokoro/release/{docs,docs-devsite,publish}.cfgfromnode:18-usertonode:22-user..kokoro/continuous/node18/and.kokoro/presubmit/{node13,node18}/with.kokoro/continuous/node22/and.kokoro/presubmit/node22/..kokoro/continuous/node14/configured withgcr.io/cloud-devrel-kokoro-resources/node:22-userso existing Kokoro triggers pointing tobuild_config_dir: "handwritten/cloud-profiler/.kokoro/continuous/node14"find the build configs and execute on Node 22.package.json:.kokoro/*.shand.kokoro/release/*.shto configurePATHfor${NPM_CONFIG_PREFIX}/bin, installpnpm@10, use--filter @google-cloud/profiler... --frozen-lockfile, setCOVERAGE_NODE=22, and guardflakybot/codecov.shexecution..kokoro/samples-test.shto skip running coverage whensamples/package.jsondoes not exist.prelintscript (cd samples; npm link ../; npm install) fromhandwritten/cloud-profiler/package.jsonand fixed lint issues insrc/index.ts,src/profiler.ts, andtest/test-init-config.ts.system-test/integration_test.goto Node 22 and 24.