Skip to content

fix(storage): re-enable docs check and update linkinator - #9257

Open
thiyaguk09 wants to merge 32 commits into
googleapis:mainfrom
thiyaguk09:fix/7338-re-enable-docs-check
Open

thiyaguk09 wants to merge 32 commits into
googleapis:mainfrom
thiyaguk09:fix/7338-re-enable-docs-check

Conversation

@thiyaguk09

@thiyaguk09 thiyaguk09 commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #7338

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Sep 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Kokoro configuration files for Node 18 documentation builds, updates various sample links in the README to reference the nodejs-docs-samples repository, and adds linkinator to automate documentation link checking. The review feedback identifies a critical configuration error in both docs.cfg files, where the TRAMPOLINE_BUILD_FILE path incorrectly references nodejs-storage instead of google-cloud-node, which will lead to Kokoro build failures.

Comment thread handwritten/storage/.kokoro/continuous/node18/docs.cfg Outdated
Comment thread handwritten/storage/.kokoro/presubmit/node18/docs.cfg Outdated
@thiyaguk09
thiyaguk09 marked this pull request as ready for review September 8, 2026 10:53
@thiyaguk09
thiyaguk09 requested review from a team as code owners September 8, 2026 10:53
@github-actions
github-actions Bot requested a review from bshaffer September 8, 2026 10:53
Comment thread .github/workflows/storage-conformance.yaml
Comment thread handwritten/storage/.kokoro/continuous/node18/docs.cfg Outdated
Comment thread handwritten/storage/linkinator.config.json
@thiyaguk09
thiyaguk09 requested a review from a team as a code owner September 22, 2026 04:58
@thiyaguk09
thiyaguk09 requested review from a team as code owners September 22, 2026 04:58
@thiyaguk09
thiyaguk09 removed request for a team September 22, 2026 05:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable docs check

2 participants