chore: update .nycrc, Contributing.md, and .gitignore across packages - #9144
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates package management and scripts from npm to pnpm across multiple packages, updating CONTRIBUTING.md files, removing package-lock.json and yarn.lock from .gitignore files, and simplifying coverage reporters in .nycrc files. Feedback highlights that some instances of npm run samples-test were missed in the CONTRIBUTING.md updates, and warns against manually editing auto-generated baseline and test-fixture files instead of updating the upstream generator templates.
|
|
||
| # Run unit tests. | ||
| npm test | ||
| pnpm run test |
There was a problem hiding this comment.
In this file (and many other CONTRIBUTING.md files across the repository), the command npm run samples-test on line 61 was missed during the migration from npm to pnpm. Please update it to pnpm run samples-test for consistency.
| 1. Install dependencies: | ||
|
|
||
| npm install | ||
| pnpm install |
There was a problem hiding this comment.
It appears that CONTRIBUTING.md (and potentially .gitignore files) in the baseline and test-fixture directories are being manually updated here. According to the repository rules, manual edits to auto-generated files or baseline files should be avoided as they will be overwritten during the next regeneration. Please ensure that the upstream generator templates (or the source files used by the generator) are updated instead, and then regenerate these baseline/test-fixture files.
References
- Do not manually edit auto-generated files to fix typos or make other changes, as these edits will be overwritten during the next regeneration. Instead, apply the fixes upstream in the generator or templates.
afc9e58 to
5b45a3c
Compare
c1db173 to
269e759
Compare
5ba1875 to
e2dbfe6
Compare
269e759 to
c3fcb0e
Compare
2 participants
Separated from #8973 to keep the core PNPM migration PR focused.
This PR standardizes subpackage configuration from the pnpm workspace migration for the following files:
.nycrc: Removes the "text" console reporter to prevent verbose CI build logs.CONTRIBUTING.md: Replacesnpmwithpnpmfor all instructions.package.json: Deletes local "pnpm.overrides" blocks..gitignore: Removespackage-lock.jsonignores.BEGIN_COMMIT_OVERIDE
fix: update .nycrc, Contributing.md, and .gitignore across packages (#9144)
END_COMMIT_OVERIDE