storage: Use standard URL to use path instead of subdomain for bucket by phw · Pull Request #638 · googleapis/google-cloud-node

phw · 2015-06-04T13:23:55Z

Fixes the SSL certificate being invalid for buckets containing dots.

E.g. if you want to access the bucket mybucket.example.com without this patch this results in the URL https://mybucket.example.com.storage.googleapis.com/ for which the SSL certificate is not valid (the certificate captures direct subdomains only). This patch uses the equally generic URL https://storage.googleapis.com/mybucket.example.com/.

…cket. Fixes the SSL certificate being invalid for buckets containing dots.

googlebot · 2015-06-04T13:23:56Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

phw · 2015-06-04T13:25:14Z

For reference: This bugs was introduced in 93d7a12

stephenplusplus · 2015-06-04T13:26:38Z

Cool, thanks. This should resolve #624 then as well, right?

phw · 2015-06-04T13:28:32Z

I signed it!

googlebot · 2015-06-04T13:28:33Z

CLAs look good, thanks!

stephenplusplus · 2015-06-04T13:29:49Z

Do you want to fix the tests or have me worry about it?

phw · 2015-06-04T13:30:50Z

I think that should fix #624 and it looks IMHO better than the fix provided there (seems a bit hacky). Will fix the unit test in a moment.

phw · 2015-06-04T13:35:42Z

Done. Or do you prefer the commits squashed together?

stephenplusplus · 2015-06-04T13:36:17Z

This is perfect, thanks very much!

storage: Use standard URL to use path instead of subdomain for bucket

phw · 2015-06-04T13:48:36Z

Thank you very much, never got anything merged upstream that fast. Saves me some headaches for the deployment today :)

stephenplusplus · 2015-06-04T15:27:52Z

Great! Never fear submitting patches and ideas here, we'll always get back pretty quickly :)

…638)

We should be running `compile-protos` as part of prepare, do so. Fixes #632

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ts-loader](https://togithub.com/TypeStrong/ts-loader) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/ts-loader/7.0.5/8.0.0) | --- ### Release Notes <details> <summary>TypeStrong/ts-loader</summary> ### [`v8.0.0`](https://togithub.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v800) [Compare Source](https://togithub.com/TypeStrong/ts-loader/compare/v7.0.5...v8.0.0) - [Support for symlinks in project references](https://togithub.com/TypeStrong/ts-loader/pull/1136) - thanks [@sheetalkamat](https://togithub.com/sheetalkamat)! - `ts-loader` now supports TypeScript 3.6 and greater **BREAKING CHANGE** </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-dialogflow).

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^14.17.3` -> `^16.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/14.17.32/16.11.6) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/compatibility-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/confidence-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-compute).

Source-Link: googleapis/synthtool@cd78529 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:ddb19a6df6c1fa081bc99fb29658f306dd64668bc26f75d1353b28296f3a78e6

* feat: v4 signed url WIP * make version an optinoal * lint * add required host header * fix canonical query params joining * add test for defaulting to v2 * fix v4 signing with test * fix tests * refactor post-signing url construction v2/v4 * add v4 tests: response-content-type and generate parameters * convert signature to HEX * add conformance test * npm run fix * remove reduntant toLowerCase * do not promisify getDate() * add system-test for v4 signing * run conformance test along with system test * fix tests * add content-md5 and content-type to signed headers if given * Object.entries in not ES5 * npm run fix * split out conformance test * test: invalid version param given * mock out Date when testing instead of override Date * use Array.map to build canonical query * refactor: use dateformat library instead of writing a function * refactor: remove unused * remove reference to deleted methods * refactor: use string interpolation and dot accessor * refactor: use method chaining * add a comment about singled valued header * refactor signedHeaders * Number(x) * refactor: use query-string module as url.parse is deprecated * npm run fix * use query-string to build canonicalQueryParams * refactor: verb => method * refactor: use sinon.FakeTimers instead of timekeeper * npm run fix * use async/await for new system-test * use async/await for new test (2) * convert getSignedUrl tests to async/await * refactor: correctly filter out undefined header values * npm run fix * make v4 multi-valued header delimiter consistent with v2, (single `,`, no space) * copy stack trace * fix: replace ALL sequential spaces * OutgoingHttpHeaders use generic type .map; rename flattenObject => objectEntries * refactor: use build-in querystring * break up v2/v4 signed url query interface * add comments about the construction of canonical headers * npm run fix * git merge failed to put code in right place * test: assert SigningError thrown * test(v4): resumable upload * prefer string.includes over indexOf * npm run fix * docs: add a note on POST and X-Goog-Resumable * SEVEN_DAYS = 604800 * emit warning when using default version * emitWarning if using default version for signing * restore stub * add new line * test: v4 signed URL: conformance test (#638) * Revert "split out conformance test" This reverts commit ce00255c738e97bf6e3e602f7cca23fae3793d05. * sync conformance-test cases; parse cases without modification * this.skip * refactor: lift interface * remove default v2 warning * docs(samples): Samples for v4 Signed URL (#654) * remove timeout on conformance-test * npm run fix

storage: Use standard URL to use the path instead of subdomain for bu…

ba888bc

…cket. Fixes the SSL certificate being invalid for buckets containing dots.

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 4, 2015

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 4, 2015

storage: Fixed unit test for file download URI change

c3c16dd

stephenplusplus added a commit that referenced this pull request Jun 4, 2015

Merge pull request #638 from phw/storage-fix-generic-url

8e98bdf

storage: Use standard URL to use path instead of subdomain for bucket

stephenplusplus merged commit 8e98bdf into googleapis:master Jun 4, 2015

stephenplusplus mentioned this pull request Jun 4, 2015

Use alternate Storage.Object.get API URL pattern to avoid SSL certifi… #624

Closed

phw deleted the storage-fix-generic-url branch June 4, 2015 13:51

This was referenced Jun 10, 2015

use path format for public URL GoogleCloudPlatform/nodejs-getting-started#3

Merged

use path format for public URL GoogleCloudPlatform/nodejs-getting-started#4

Merged

use path format for public URL GoogleCloudPlatform/nodejs-getting-started#5

Merged

sofisl mentioned this pull request Oct 11, 2022

migrate code from googleapis/nodejs-language #3395

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Oct 11, 2022

docs(badges): tweak badge to use new preview/stable language (#1314) (#…

8d99a54

…638)

sofisl pushed a commit that referenced this pull request Oct 13, 2022

docs(badges): tweak badge to use new preview/stable language (#1314) (#…

92c426b

…638)

sofisl mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-translate #3520

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 10, 2022

build: compile-protos should be part of prepare (#638)

254ba13

We should be running `compile-protos` as part of prepare, do so. Fixes #632

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-dialogflow #3546

Merged

4 tasks

sofisl mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-compute #3666

Merged

4 tasks

miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025

chore(deps): update dependency typescript to ~3.7.0 (#638)

2c29525

GautamSharda pushed a commit that referenced this pull request Jan 14, 2026

chore(deps): update dependency gaxios to v5 (#638)

9588c8f

GautamSharda pushed a commit that referenced this pull request Jan 15, 2026

chore(deps): update dependency gaxios to v5 (#638)

297b694

GautamSharda mentioned this pull request Jan 20, 2026

chore: migrate code from googleapis/nodejs-error-reporting #7019

Closed

4 tasks

miguelvelezsa pushed a commit that referenced this pull request Jan 28, 2026

fix(deps): update dependency @grpc/grpc-js to v0.7.8 (#638)

c952598

miguelvelezsa mentioned this pull request Jan 28, 2026

migrate code from googleapis/nodejs-datastore #7053

Closed

sofisl mentioned this pull request Feb 4, 2026

migrate code from googleapis/nodejs-logging-bunyan #7136

Closed

4 tasks

This was referenced Feb 4, 2026

migrate code from googleapis/nodejs-logging-bunyan #7137

Closed

migrate code from googleapis/nodejs-logging-bunyan #7138

Merged

migrate code from googleapis/nodejs-datastore #7148

Closed

sofisl pushed a commit that referenced this pull request Feb 5, 2026

fix(deps): update dependency @grpc/grpc-js to v0.7.8 (#638)

480c3fe

GautamSharda mentioned this pull request Feb 5, 2026

migrate code from googleapis/nodejs-error-reporting #7169

Closed

4 tasks

GautamSharda pushed a commit that referenced this pull request Feb 5, 2026

chore(deps): update dependency gaxios to v5 (#638)

e8fff77

sofisl mentioned this pull request Feb 17, 2026

migrate code from googleapis/nodejs-datastore #7263

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Feb 17, 2026

fix(deps): update dependency @grpc/grpc-js to v0.7.8 (#638)

1872b58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

storage: Use standard URL to use path instead of subdomain for bucket#638

storage: Use standard URL to use path instead of subdomain for bucket#638
stephenplusplus merged 2 commits intogoogleapis:masterfrom
phw:storage-fix-generic-url

phw commented Jun 4, 2015

Uh oh!

googlebot commented Jun 4, 2015

Uh oh!

phw commented Jun 4, 2015

Uh oh!

stephenplusplus commented Jun 4, 2015

Uh oh!

phw commented Jun 4, 2015

Uh oh!

googlebot commented Jun 4, 2015

Uh oh!

stephenplusplus commented Jun 4, 2015

Uh oh!

phw commented Jun 4, 2015

Uh oh!

phw commented Jun 4, 2015

Uh oh!

stephenplusplus commented Jun 4, 2015

Uh oh!

phw commented Jun 4, 2015

Uh oh!

stephenplusplus commented Jun 4, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

phw commented Jun 4, 2015

Uh oh!

googlebot commented Jun 4, 2015

Uh oh!

phw commented Jun 4, 2015

Uh oh!

stephenplusplus commented Jun 4, 2015

Uh oh!

phw commented Jun 4, 2015

Uh oh!

googlebot commented Jun 4, 2015

Uh oh!

stephenplusplus commented Jun 4, 2015

Uh oh!

phw commented Jun 4, 2015

Uh oh!

phw commented Jun 4, 2015

Uh oh!

stephenplusplus commented Jun 4, 2015

Uh oh!

phw commented Jun 4, 2015

Uh oh!

stephenplusplus commented Jun 4, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants