language: fix system tests#1739
Merged
callmehiphop merged 1 commit intogoogleapis:masterfrom Oct 21, 2016
Merged
Conversation
stephenplusplus
added
api: language
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
This was referenced Jan 2, 2024
sofisl
pushed a commit
that referenced
this pull request
Feb 24, 2026
Co-authored-by: Denver Coneybeare <dconeybe@google.com> Co-authored-by: Tom Andersen <tom-andersen@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Feb 25, 2026
sofisl
pushed a commit
that referenced
this pull request
Feb 26, 2026
* fix: cleanup different types of session pools * fix: revert some changes to prevent backward compatibility breakage * fix: revert some changes to prevent backward compatibility breakage * fix: deprecated getReadSession and getWriteSession methods * fix: add `session-available` event * fix: addressing code review feedbacks * fix: minor documentation updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the Language system tests had a failure. Fixed that. But also, the terminal wasn't doing any reporting of the error-- it just exited the mocha process quietly. Wrapping the tests in a try/catch corrected this.