Added batch concept supporting list zones calls only.#765
Added batch concept supporting list zones calls only.#765mderka wants to merge 1 commit intogoogleapis:dns-alpha-batchfrom
Conversation
googlebot
added
the
cla: yes
| import static com.google.common.base.Preconditions.checkNotNull; | ||
|
|
||
| import com.google.api.services.dns.model.ManagedZone; | ||
| import com.google.common.base.Function; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I did a first pass. There are a couple of comments that are worth discussing. I know that we already discussed this but seeing it done makes me think whether implementing batch with callbacks could give users the wrong idea that something is happening asynchronously. It feels slightly confusing to me. |
|
I think that we need to make a joint decision on what should be done with the As far as the callbacks go, would you do instead? I think that futures also make the hint to asynchronous processing. I agree that we should specifically say that no asynchronous processing is happening in the docs, but I still like the callbacks. (Check the design doc for our initial discussion.) Do you maybe want to schedule a meeting about it? |
mderka
added
the
do not merge
|
We decided to go for a different concept. Closing. |
…-plugin to v3.4.0 (googleapis#765) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) | `3.3.2` -> `3.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).
](https://renovatebot.com){kind=link}
Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.
4 participants
This commit contains a concept of batches. It currently supports a single operation (list zones) only, but it is functional and contains the entire stack including tests. If this gets approved, I will proceed by implementing the remaining methods.