Skip to content

Completes DnsRpc interface by adding methods and doc. Implements DefaultDnsRpc.#616

Merged
aozarov merged 4 commits intogoogleapis:dns-alphafrom
mderka:dns-options
Feb 4, 2016
Merged

Completes DnsRpc interface by adding methods and doc. Implements DefaultDnsRpc.#616
aozarov merged 4 commits intogoogleapis:dns-alphafrom
mderka:dns-options

Conversation

@mderka
Copy link

@mderka mderka commented Feb 3, 2016

Closes #594.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2016
@mderka mderka added the api: dns Issues related to the Cloud DNS API. label Feb 3, 2016
@mderka mderka added this to the DNS Stable milestone Feb 3, 2016
@mderka mderka changed the title Completes DnsRpc interface by adding methods and doc. Completes DnsRpc interface by adding methods and doc. Implements DefaultDnsRpc. Feb 3, 2016
@mderka
Copy link
Author

mderka commented Feb 3, 2016

DefaultDnsRpc is to be tested within integration tests in #617.

mziccard
mziccard reviewed Feb 3, 2016
View reviewed changes
gcloud-java-dns/src/main/java/com/google/gcloud/spi/DefaultDnsRpc.java Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@mziccard
Copy link
Contributor

mziccard commented Feb 3, 2016

Not related to this PR. I think that the method Dns.getProjectInfo() should be called getProject.

@mderka
Copy link
Author

mderka commented Feb 3, 2016

Fixed all except getProject()---see above.

Regarding Dns.getProjectInfo(), I would agree if Project was functional, but it really is just a container for project quota. There are no methods that you can call on it which would contact the service. Would that not be a bit confusing?

@mderka
Copy link
Author

mderka commented Feb 4, 2016

Ok. Please, check this despite the coverall drop. See the top comment regarding tests.

aozarov
aozarov reviewed Feb 4, 2016
View reviewed changes
gcloud-java-dns/src/main/java/com/google/gcloud/spi/DnsRpc.java
import com.google.api.services.dns.model.Project;
import com.google.api.services.dns.model.ResourceRecordSet;
import com.google.gcloud.dns.DnsException;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mderka @mziccard @aozarov @googlebot