Remove JobInfo hierarchy, add JobConfiguration hierarchy#584
Merged
aozarov merged 6 commits intogoogleapis:masterfrom Jan 29, 2016
Merged
Remove JobInfo hierarchy, add JobConfiguration hierarchy#584aozarov merged 6 commits intogoogleapis:masterfrom
aozarov merged 6 commits intogoogleapis:masterfrom
Conversation
e0a6fec to
84402ac
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Done withe the review. looks good. Main comment (as discussed verbally) is the suggestion to make JobConfiguration interface an abstract class (and use package scope methods to set or get from pb). |
022ad08 to
d170550
Compare
d170550 to
a2c8b39
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Looks great! Do you plan to do the same for BaseTableInfo ? BTW, looks like BigQueryException has 2 unused import statements. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
JobInfohierarchy and replaces it with a hierarchy onJobConfiguration. This change is needed to make functionalJobextendJobInfo. Notes:CopyJobConfiguration,ExtractJobConfiguration,LoadJobConfigurationorQueryJobConfiguration) must be provided to create aJobInfoobject.LoadJobConfigurationalso extendsLoadConfigurationwhich is used for resumable uploadsJobConfigurationis an interface with only atype()method since configurations have no common data (this is also required to makeLoadJobConfigurationextendLoadConfiguration).