Add query request and query response classes and tests#452
Merged
aozarov merged 4 commits intogoogleapis:bigqueryfrom Dec 14, 2015
Merged
Add query request and query response classes and tests#452aozarov merged 4 commits intogoogleapis:bigqueryfrom
aozarov merged 4 commits intogoogleapis:bigqueryfrom
Conversation
googlebot
added
the
cla: yes
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
Ehi guys, thanks for the feedback. I fixed all comments and answered the open questions. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
- Add better javadoc and snippet to QueryResponse - Use primitive boolean for jobComplete - Add test for NPE in QueryRequestTests - Add QueryRequest and QueryResponse to SerializationTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds classes for Query Requests and Query Responses:
QueryRequestis used to run queries "on the fly" Jobs: queryQueryResponseis used to both hold the result of queries run on the fly (Jobs: query) and to hold the result of query jobs (Jobs: getQueryResults)Remarks
QueryResponsehas nofromPbmethod as it is initialized through the builder inside theBigQueryServiceImplclass. This is so because:Page<List<FieldValue>> rowsQueryResponseis created from 2 pb classes: QueryResponse and GetQueryResultsResponseI preferred to handle the creation inside
BigQueryServiceImplrather than having afromPbmethod with more parameters.