Using the right compare function for FieldPaths#3189
Merged
Conversation
googlebot
added
the
cla: yes
pongad
reviewed
Apr 25, 2018
| groups[38] = new Value[] {referenceValue("projects/p1/databases/d1/documents/c2/doc1")}; | ||
| groups[39] = new Value[] {referenceValue("projects/p2/databases/d2/documents/c1/doc1")}; | ||
| groups[40] = new Value[] {referenceValue("projects/p2/databases/d2/documents/c1-/doc1")}; | ||
| groups[40] = new Value[] {referenceValue("projects/p2/databases/d3/documents/c1-/doc1")}; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @Override | ||
| public int compareTo(@Nonnull FieldPath other) { | ||
| return getEncodedPath().compareTo(other.getEncodedPath()); | ||
| return super.compareTo(other); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
🤖 I have created a release *beep* *boop* --- ## [2.38.2](https://togithub.com/googleapis/java-bigquery/compare/v2.38.1...v2.38.2) (2024-03-21) ### Dependencies * Update actions/checkout action ([#3190](https://togithub.com/googleapis/java-bigquery/issues/3190)) ([940e4f6](https://togithub.com/googleapis/java-bigquery/commit/940e4f6c656a2e0f1d2e4d6e08d42214d14fe125)) * Update arrow.version to v15.0.1 ([#3189](https://togithub.com/googleapis/java-bigquery/issues/3189)) ([fb6284e](https://togithub.com/googleapis/java-bigquery/commit/fb6284e94d4744bb4c8f9501751bf79e04a2429b)) * Update dependency com.google.api.grpc:proto-google-cloud-bigqueryconnection-v1 to v2.39.0 ([#3186](https://togithub.com/googleapis/java-bigquery/issues/3186)) ([9e705a1](https://togithub.com/googleapis/java-bigquery/commit/9e705a140ac6fc1d1d64674dc985c35955911667)) * Update dependency com.google.apis:google-api-services-bigquery to v2-rev20240229-2.0.0 ([#3188](https://togithub.com/googleapis/java-bigquery/issues/3188)) ([a018424](https://togithub.com/googleapis/java-bigquery/commit/a018424ccbf3c2c554d829c97e442f4813b2c764)) * Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.43.0 ([#3187](https://togithub.com/googleapis/java-bigquery/issues/3187)) ([497ff29](https://togithub.com/googleapis/java-bigquery/commit/497ff298d84e536161b112c6b1aa176d4d962a49)) * Update dependency com.google.cloud:sdk-platform-java-config to v3.28.1 ([#3196](https://togithub.com/googleapis/java-bigquery/issues/3196)) ([61f23a3](https://togithub.com/googleapis/java-bigquery/commit/61f23a35d2b5cbbd66ddf35b93709a5669b5b102)) * Update github/codeql-action action to v2.24.6 ([#3178](https://togithub.com/googleapis/java-bigquery/issues/3178)) ([8843cae](https://togithub.com/googleapis/java-bigquery/commit/8843cae621e1eede6b072b1347f2a68a36304bca)) * Update github/codeql-action action to v2.24.7 ([#3194](https://togithub.com/googleapis/java-bigquery/issues/3194)) ([2e2d730](https://togithub.com/googleapis/java-bigquery/commit/2e2d730de9e4e49f25c20de2cfe1ae38babef830)) * Update github/codeql-action action to v2.24.8 ([#3198](https://togithub.com/googleapis/java-bigquery/issues/3198)) ([bd81a56](https://togithub.com/googleapis/java-bigquery/commit/bd81a56a07c836abb05c1de0d42e9cd397920e99)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to compare field paths segment per segment and not use the encoded paths.