Skip to content

BigQuery: schemaUpdateOptions support#1647

Merged
shinfan merged 1 commit intogoogleapis:masterfrom
telligent-data:feature/bq-schema-update-options
Mar 21, 2017
Merged

BigQuery: schemaUpdateOptions support#1647
shinfan merged 1 commit intogoogleapis:masterfrom
telligent-data:feature/bq-schema-update-options

Conversation

@gene-telligent
Copy link
Copy Markdown

Fix for #1566 .

Implements schemaUpdateOptions for both BigQuery LoadJobConfigurations and QueryJobConfigurations.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 23, 2017
@gene-telligent gene-telligent force-pushed the feature/bq-schema-update-options branch from f73cfc7 to ba24be3 Compare February 23, 2017 01:29
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.01%) to 81.084% when pulling f73cfc7 on telligent-data:feature/bq-schema-update-options into a599972 on GoogleCloudPlatform:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 81.137% when pulling ba24be3 on telligent-data:feature/bq-schema-update-options into a599972 on GoogleCloudPlatform:master.

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

@tswast could you take a look?

Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This appears correct to me.

This schemaUpdateOptions is a list of values ALLOW_FIELD_ADDITION and ALLOW_FIELD_RELAXATION, and it applies to load jobs and query jobs.

@garrettjonesgoogle Can you confirm that enums are handled in the way expected by the google-cloud-java libraries?

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

@shinfan could you check into @tswast 's question?

@shinfan
Copy link
Copy Markdown
Contributor

shinfan commented Mar 21, 2017

LGTM

@gene-telligent gene-telligent force-pushed the feature/bq-schema-update-options branch from ba24be3 to 1865c47 Compare March 21, 2017 23:12
@gene-telligent
Copy link
Copy Markdown
Author

Hey all,

I've fixed / rebased the merge conflicts (currently waiting for the CI builds to complete). Afterwards, feel free to merge when you need to!

@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 1865c47 on telligent-data:feature/bq-schema-update-options into ** on GoogleCloudPlatform:master**.

@shinfan shinfan merged commit 0a2bf7f into googleapis:master Mar 21, 2017
@shinfan
Copy link
Copy Markdown
Contributor

shinfan commented Mar 21, 2017

Thanks for fixing this

@gene-telligent gene-telligent deleted the feature/bq-schema-update-options branch March 23, 2017 00:50
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants