Add ID token verification helpers. by theacodes · Pull Request #82 · googleapis/google-auth-library-python

theacodes · 2016-11-10T20:38:42Z

Resolves #39 and the v1.0.0 milestone.

dhermes

LGTM. Don't you want to return a boolean instead of the actual certs?

google/oauth2/id_token.py

+    '/securetoken@system.gserviceaccount.com')
+
+
+def _fetch_certs(request, certs_url):


google/oauth2/id_token.py

+        raise exceptions.TransportError(
+            'Could not fetch certificates at {}'.format(certs_url))
+
+    return json.loads(response.data.decode('utf-8'))


google/oauth2/id_token.py

+        id_token (Union[str, bytes]): The encoded token.
+        request (google.auth.transport.Request): The object used to make
+            HTTP requests.
+        audience (str): The audience that this token is intended for. If None


google/oauth2/id_token.py

+            HTTP requests.
+        audience (str): The audience that this token is intended for. If None
+            then the audience is not verified.
+        certs_url (str): The URL that specifies the certificates to use to


google/oauth2/id_token.py

+        id_token (Union[str, bytes]): The encoded token.
+        request (google.auth.transport.Request): The object used to make
+            HTTP requests.
+        audience (str): The audience that this token is intended for. This is


google/oauth2/id_token.py

+        Mapping[str, Any]: The decoded token.
+
+    Raises:
+        ValueError: if verification fails.


google/oauth2/id_token.py

+        Mapping[str, Any]: The decoded token.
+
+    Raises:
+        ValueError: if verification fails.


google/oauth2/id_token.py

+        certs_url=_GOOGLE_OAUTH2_CERTS_URL)
+
+
+def verify_firebase_token(id_token, request, audience=None):


tests/oauth2/test_id_token.py

+    response = mock.Mock()
+    response.status = status
+
+    if data is not None:


Add ID token verification helpers.

a6964da

theacodes added this to the 1.0.0 milestone Nov 10, 2016

theacodes assigned dhermes Nov 10, 2016

dhermes approved these changes Nov 10, 2016

View reviewed changes

Address review comments

40fece8

theacodes merged commit e2ab100 into master Nov 10, 2016

theacodes deleted the id-token branch November 10, 2016 23:11

theacodes unassigned dhermes Oct 11, 2018

		'/securetoken@system.gserviceaccount.com')


		def _fetch_certs(request, certs_url):

		certs_url=_GOOGLE_OAUTH2_CERTS_URL)


		def verify_firebase_token(id_token, request, audience=None):

Conversation

theacodes commented Nov 10, 2016

Uh oh!

dhermes left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants