Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

Swap target, request for request, target in secure_authorized_channel's argument order.#81

Merged
theacodes merged 2 commits intomasterfrom
swap-grpc-arg-order
Nov 10, 2016
Merged

Swap target, request for request, target in secure_authorized_channel's argument order.#81
theacodes merged 2 commits intomasterfrom
swap-grpc-arg-order

Conversation

@theacodes
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why?

@theacodes
Copy link
Copy Markdown
Contributor Author

@dhermes because the previous argument order just didn't flow logically to me, it was previously auth object, grpc object, auth object, grpc object, now it's auth object, auth object, grpc object, grpc object.

@theacodes theacodes merged commit 840b3ac into master Nov 10, 2016
@theacodes theacodes deleted the swap-grpc-arg-order branch November 10, 2016 20:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants