Expose id_token in OAuth 2.0 credentials by theacodes · Pull Request #150 · googleapis/google-auth-library-python

theacodes · 2017-03-27T20:46:33Z

Resolves #149

google/oauth2/credentials.py

        """Optional[str]: The OAuth 2.0 client secret."""
        return self._client_secret

+    @property


google/oauth2/service_account.py

    def refresh(self, request):
        assertion = self._make_authorization_grant_assertion()
-        access_token, expiry, _ = _client.jwt_grant(
+        access_token, expiry, refresh_grant_response = _client.jwt_grant(


theacodes · 2017-03-28T19:43:39Z

@dhermes updated. PTAL.

google/oauth2/credentials.py

        self._token_uri = token_uri
        self._client_id = client_id
        self._client_secret = client_secret
+        self._refresh_grant_response = None


google/oauth2/credentials.py

        self.token = access_token
        self.expiry = expiry
        self._refresh_token = refresh_token
+        self._id_token = grant_response.get('id_token', self._id_token)


Expose the refresh grant response in OAuth 2.0 credentials

8f7066d

theacodes added this to the 1.0.0 milestone Mar 27, 2017

theacodes requested review from dhermes and lukesneeringer March 27, 2017 20:46

dhermes reviewed Mar 28, 2017

View reviewed changes

Expose only the id token

0a5d082

theacodes changed the title ~~Expose the refresh grant response in OAuth 2.0 credentials~~ Expose id_token in OAuth 2.0 credentials Mar 28, 2017

dhermes reviewed Mar 28, 2017

View reviewed changes

Jon Wayne Parrott added 2 commits March 28, 2017 12:48

Remove lingering property

7c0cc4a

Make id_token match the last response from the authorization server

0c82e86

dhermes approved these changes Mar 28, 2017

View reviewed changes

theacodes merged commit 26a1637 into master Mar 28, 2017

theacodes deleted the token-response branch March 28, 2017 20:03

Conversation

theacodes commented Mar 27, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

theacodes commented Mar 28, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants