Skip to content

[ci] Roll pinned nightly toolchain#1081

Closed
google-pr-creation-bot wants to merge 1 commit into
google:mainfrom
google-pr-creation-bot:roll-pinned-nightly-toolchain-to-nightly-2024-03-29
Closed

[ci] Roll pinned nightly toolchain#1081
google-pr-creation-bot wants to merge 1 commit into
google:mainfrom
google-pr-creation-bot:roll-pinned-nightly-toolchain-to-nightly-2024-03-29

Conversation

@google-pr-creation-bot

Copy link
Copy Markdown
Contributor

Automated changes by create-pull-request GitHub action

@jswrenn

jswrenn commented Mar 30, 2024

Copy link
Copy Markdown
Collaborator

The CI breakage was caused by syn bumping its MSRV to 1.60. The timeline of events is a little confusing:

  1. March 21: Raise required compiler to rust 1.60
  2. March 23: Release 2.0.54
  3. March 23: Restore compatibility with rustc 1.56 through 1.59
  4. March 23: Release 2.0.55
  5. March 29: chore: bump msrv to 1.60 in Use dep: and optional dependency feature ? syntax dtolnay/syn#1608
  6. March 29: Release 2.0.56

Not yet sure how we should proceed with this. A few possibilities that spring to mind:

  • We build in CI with -Z minimal-versions
  • We downgrade to syn 1.x (MSRV is 1.31)
  • We vendor (or reimplement) the parts of syn relevant to zerocopy-derive
  • We delete our MSRV policy on zerocopy-derive; we cannot guarantee an MSRV for that crate, since it has dependencies with different MSRV policies.

@joshlf

joshlf commented Apr 3, 2024

Copy link
Copy Markdown
Member

Obsoleted by #1090

@joshlf joshlf closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants