Conversation
jhughesoti
commented
Sep 8, 2023
Contributor
|
We need to get automated testing passing before merging |
Signed-off-by: J Boddey <boddey@google.com>
Signed-off-by: J Boddey <boddey@google.com>
jboddey
approved these changes
Sep 18, 2023
hitnik
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Change ntp server to use chronyd * Minor fixes to dhcp builds * Add conf line * Try CI network again * Update chrony.conf * Remove ntp from testing * Disable protocol module Signed-off-by: J Boddey <boddey@google.com> --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: Jacob Boddey <boddey@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch ntp server to use chronyd. Similar design pattern used for dhcp server and isc which will allow for implementing gRPC interactions when necessary for ntp related testing.