Skip to content

fix(blueprints): configure GitLab Cloud SQL private network - #339

Merged
aghassemlouei merged 1 commit into
google:mainfrom
huong8373tt-beep:fix/313-gitlab-cloudsql-private-network
Oct 22, 2026
Merged

aghassemlouei merged 1 commit into
google:mainfrom
huong8373tt-beep:fix/313-gitlab-cloudsql-private-network

Conversation

@huong8373tt-beep

@huong8373tt-beep huong8373tt-beep commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes #313.

blueprints/third-party-solutions/gitlab/services.tf passed network_config.connectivity.psa_configs (a list) to modules/cloudsql-instance, which declares network_config.connectivity.psa_config (a singular object). Terraform silently discarded the undeclared psa_configs attribute, leaving the Cloud SQL instance without its private network attachment. This change passes var.network_config.network_self_link via connectivity.psa_config.private_network.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Deployment & Compliance Impact

  • Applicable Regimes:
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • General / All
  • NIST 800-53r5 Controls: SC-7

Checklist

Code Quality & Reusability

  • My code adheres to the Maximize Reusability principle. I have not redefined common elements and have reused existing base configurations and modules where possible.
  • I have checked that no existing module or configuration in modules/ or fast/stages-aw/ can be leveraged for this change.
  • My code follows the established naming conventions outlined in docs/naming-convention.md.

Documentation

  • I have updated the README.md of the modified module or blueprint.
  • I have added/updated documentation for inputs (variables) and outputs.

Security

  • My change adheres to GCP security best practices and the principle of least privilege.
  • I have ensured compliance with the targeted regime (FedRAMP Moderate, FedRAMP High, IL4, IL5, etc.).

Testing

  • I have tested my changes locally.
  • I have included details of my testing in this PR.

Testing Performed

  • Executed bash tools/run_tests.sh and bash tools/lint.sh.
  • Verified with terraform init and terraform plan in blueprints/third-party-solutions/gitlab that module.db.google_sql_database_instance.primary.settings[0].ip_configuration[0].private_network is populated with var.network_config.network_self_link.

@github-actions github-actions Bot added the Scope - Blueprint Related to solution blueprints in the blueprints directory label Oct 22, 2026
@google-cla

google-cla Bot commented Oct 22, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@aghassemlouei
aghassemlouei force-pushed the fix/313-gitlab-cloudsql-private-network branch from 91dbc9d to a398c5b Compare October 22, 2026 14:54
@aghassemlouei aghassemlouei added Bug Something isn't working Security Something is insecure or can be secured Priority - High Critical issues blocking development or users; urgent bugs or core features for release Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete labels Oct 22, 2026
@aghassemlouei
aghassemlouei force-pushed the fix/313-gitlab-cloudsql-private-network branch from a398c5b to 91dbc9d Compare October 22, 2026 15:09

@aghassemlouei aghassemlouei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the Cloud SQL private network attribute in the GitLab blueprint, @huong8373tt-beep! Verified that the private network self link now populates on the database instance.

@aghassemlouei
aghassemlouei merged commit 7a5c594 into google:main Oct 22, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Level of Effort - Low Quick, well-defined tasks with no unknowns; takes a few hours up to one day to complete Priority - High Critical issues blocking development or users; urgent bugs or core features for release Scope - Blueprint Related to solution blueprints in the blueprints directory Security Something is insecure or can be secured

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] third-party-solutions/gitlab: the Cloud SQL database gets no private network, because psa_configs is not a cloudsql-instance attribute

2 participants