Add compile flag option for not including flowgraph#2302
Merged
Conversation
flamme
reviewed
Aug 29, 2025
flamme
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new compile flag to not use the flowgraph. Since AAudio has included sample rate conversion in Android V, there is not strong reason we need to use the flowgraph anymore. Adding a compiler flag to turn this off. This saves half the binary size for Oboe
With -DOBOE_DISABLE_CONVERSION=OFF
With -DOBOE_DISABLE_CONVERSION=ON
Note that cleaning the project doesn't remove the flag if you set it.
For me, if I enable it once in OboeTester, I need to manually remove it in /Users/robertwu/Documents/oboe/apps/OboeTester/app/.cxx/Debug/41t402x1/arm64-v8a/CMakeCache.txt or remove the .cxx subdirectory to delete it