Skip to content

Add compile flag option for not including flowgraph#2302

Merged
robertwu1 merged 4 commits intomainfrom
robertwu/testnotincludingflowgraph
Aug 29, 2025
Merged

Add compile flag option for not including flowgraph#2302
robertwu1 merged 4 commits intomainfrom
robertwu/testnotincludingflowgraph

Conversation

@robertwu1
Copy link
Copy Markdown
Collaborator

@robertwu1 robertwu1 commented Aug 29, 2025

This PR introduces a new compile flag to not use the flowgraph. Since AAudio has included sample rate conversion in Android V, there is not strong reason we need to use the flowgraph anymore. Adding a compiler flag to turn this off. This saves half the binary size for Oboe

With -DOBOE_DISABLE_CONVERSION=OFF

robertwu-mac:arm64-v8a robertwu$ ls -l
total 7304
-rw-r--r--   1 robertwu  primarygroup     3522 Aug 29 11:40 cmake_install.cmake
-rw-r--r--   1 robertwu  primarygroup    17017 Aug 29 11:40 CMakeCache.txt
drwxr-xr-x@ 16 robertwu  primarygroup      512 Aug 29 11:40 CMakeFiles
-rwxr-xr-x@  1 robertwu  primarygroup  3630584 Aug 29 11:40 liboboe.so
-rw-r--r--   1 robertwu  primarygroup    78452 Aug 29 11:40 Makefile
drwxr-xr-x   2 robertwu  primarygroup       64 Dec 16  2024 staging

With -DOBOE_DISABLE_CONVERSION=ON

robertwu-mac:arm64-v8a robertwu$ ls -l
total 3672
-rw-r--r--   1 robertwu  primarygroup     3522 Aug 29 11:40 cmake_install.cmake
-rw-r--r--   1 robertwu  primarygroup    17016 Aug 29 11:38 CMakeCache.txt
drwxr-xr-x@ 16 robertwu  primarygroup      512 Aug 29 11:40 CMakeFiles
-rwxr-xr-x@  1 robertwu  primarygroup  1815848 Aug 29 11:40 liboboe.so
-rw-r--r--   1 robertwu  primarygroup    35600 Aug 29 11:40 Makefile
drwxr-xr-x   2 robertwu  primarygroup       64 Dec 16  2024 staging

Note that cleaning the project doesn't remove the flag if you set it.
For me, if I enable it once in OboeTester, I need to manually remove it in /Users/robertwu/Documents/oboe/apps/OboeTester/app/.cxx/Debug/41t402x1/arm64-v8a/CMakeCache.txt or remove the .cxx subdirectory to delete it

@robertwu1 robertwu1 changed the title WIP: Test adding compile flag option for not including flowgraph Add compile flag option for not including flowgraph Aug 29, 2025
@robertwu1 robertwu1 requested a review from flamme August 29, 2025 18:58
@robertwu1 robertwu1 requested a review from flamme August 29, 2025 21:40
@robertwu1 robertwu1 merged commit 6a5ea3a into main Aug 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants