OboeTester: Add package name and attribution tag#2206
Merged
Conversation
philburk
reviewed
Apr 30, 2025
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/AudioStreamTester.java
Outdated
Show resolved
Hide resolved
flamme
reviewed
Apr 30, 2025
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/OboeAudioStream.java
Outdated
Show resolved
Hide resolved
apps/OboeTester/app/src/main/java/com/mobileer/oboetester/AudioStreamTester.java
Outdated
Show resolved
Hide resolved
Collaborator
|
BTW, from a test purpose, do we want to allow to random set package name and attribution tag when opening streams? |
Collaborator
Author
We can but tbh it'll cluster the UI as we almost never use this. I added an example in the unit tests |
Collaborator
I was thinking it would be handy to test some permission issues. |
flamme
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds package names and attribution tags to OboeTester. These should be declared for audio streams or there may be permission issues with microphone permissions.