[PCM Offload] PowerPlay Sample App Implementation#2197
Merged
madebymozart merged 18 commits intomainfrom Jul 23, 2025
Merged
Conversation
madebymozart
added
P1
madebymozart
force-pushed
the
powerplay-sample
branch
from
dc35492 to
090d355
Compare
* Add offload support. Fixes #2154.
madebymozart
force-pushed
the
powerplay-sample
branch
from
090d355 to
ca26007
Compare
madebymozart
commented
Apr 8, 2025
flamme
reviewed
Apr 9, 2025
Collaborator
flamme
left a comment
flamme
left a comment
There was a problem hiding this comment.
This change should be rebased so that the commit doesn't show the already merged PR.
philburk
reviewed
Apr 11, 2025
robertwu1
reviewed
Apr 15, 2025
robertwu1
reviewed
Apr 15, 2025
robertwu1
reviewed
Apr 15, 2025
robertwu1
reviewed
Apr 15, 2025
Collaborator
Author
|
Opening a new pr that extracts this app into a standalone to avoid making changes to some of the shared libraries |
robertwu1
reviewed
Jul 16, 2025
robertwu1
reviewed
Jul 16, 2025
robertwu1
reviewed
Jul 16, 2025
robertwu1
reviewed
Jul 16, 2025
robertwu1
reviewed
Jul 16, 2025
robertwu1
reviewed
Jul 16, 2025
robertwu1
reviewed
Jul 16, 2025
robertwu1
reviewed
Jul 16, 2025
flamme
reviewed
Jul 16, 2025
robertwu1
reviewed
Jul 16, 2025
robertwu1
reviewed
Jul 16, 2025
robertwu1
reviewed
Jul 16, 2025
robertwu1
reviewed
Jul 16, 2025
robertwu1
reviewed
Jul 16, 2025
flamme
reviewed
Jul 16, 2025
| // The aaudio device type and aaudio policy were added in NDK 28, | ||
| // which is the first version to support Android W (API 36). | ||
| #if __NDK_MAJOR__ >= 29 | ||
| #if __NDK_MAJOR__ >= 30 |
Collaborator
There was a problem hiding this comment.
This seems need to be verified. BTW, the comment above should be changed for consistency
| #endif | ||
|
|
||
| #if OBOE_USING_NDK && __NDK_MAJOR__ < 29 | ||
| #if OBOE_USING_NDK && __NDK_MAJOR__ < 30 |
Collaborator
There was a problem hiding this comment.
We may need to verify this. NDK 30 is not yet available. Does NDK 29 beta 2 have it? https://groups.google.com/g/android-ndk-announce/c/3A_x9XLSZNw
Collaborator
Author
There was a problem hiding this comment.
It doesn't unfortunately
flamme
reviewed
Jul 23, 2025
robertwu1
reviewed
Jul 23, 2025
robertwu1
reviewed
Jul 23, 2025
flamme
reviewed
Jul 23, 2025
flamme
approved these changes
Jul 23, 2025
robertwu1
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the powerplay sample app, which allows a user, through oboe, to choose a new performance mode that allows the CPU to sleep significantly more, thus aiding in it's ability to save power.