Conversation
sharingMode and the hardware formats were not getting copied. It was noticed in OboeTester. The test specs for TEST DISCONNECT were made more rational. Also a unit test was added to catch the oboe bug. Fixes #1897
robertwu1
reviewed
Aug 15, 2023
tests/testStreamOpen.cpp
Outdated
| mBuilder.setSampleRate(44100); | ||
| mBuilder.setSampleRateConversionQuality(SampleRateConversionQuality::Medium); | ||
| ASSERT_TRUE(openStream()); | ||
| ASSERT_LT(0, mStream->getHardwareSampleRate()); |
Collaborator
There was a problem hiding this comment.
getHardware* functions are only supported in Android API 34+. Please wrap this test around an SDK level check.
robertwu1
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sharingMode and the hardware formats were not getting copied.
It was noticed in OboeTester.
The test specs for TEST DISCONNECT were made more rational.
Also a unit test was added to catch the oboe bug.
Fixes #1897