Conversation
flamme
reviewed
Mar 21, 2023
flamme
approved these changes
Mar 21, 2023
Collaborator
flamme
left a comment
flamme
left a comment
There was a problem hiding this comment.
The PR looks good to me. Thanks for making the change!
philburk
reviewed
Mar 24, 2023
Contributor
|
Can this be tested? |
Collaborator
Author
You can test opening the stream with OboeTester. By looking at the device report, if encoding 13 is supported, then this should open for API 34+. |
Contributor
|
You can test using OboeTester by selecting IEC61937 |
Collaborator
Author
Good test! This works for SampleRate=32000 but fails for SampleRate=96000 on the TV I tested as 32000 is supported on the TV but not 96000. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1757