OpenSL ES: Return ErrorInvalidFormat instead of ErrorInternal for invalid format#1634
Merged
OpenSL ES: Return ErrorInvalidFormat instead of ErrorInternal for invalid format#1634
Conversation
flamme
reviewed
Sep 28, 2022
philburk
suggested changes
Sep 28, 2022
Contributor
philburk
left a comment
philburk
left a comment
There was a problem hiding this comment.
Look for other format check in Oboe.
robertwu1
changed the title
Collaborator
Author
Done. Thanks for the suggestion! |
flamme
approved these changes
Oct 12, 2022
philburk
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSL ES only supports float and I16. We should return that other formats are invalid if OpenSL ES is used. Otherwise, it may be hard for developers to debug.