opensles: implement capacity using buffer queue length#1601
Merged
Conversation
robertwu1
reviewed
Aug 8, 2022
robertwu1
reviewed
Aug 8, 2022
robertwu1
reviewed
Aug 8, 2022
robertwu1
reviewed
Aug 8, 2022
robertwu1
requested changes
Aug 8, 2022
Collaborator
robertwu1
left a comment
robertwu1
left a comment
There was a problem hiding this comment.
Added some comments. Thanks!
robertwu1
reviewed
Aug 8, 2022
philburk
commented
Aug 8, 2022
robertwu1
reviewed
Aug 8, 2022
robertwu1
approved these changes
Aug 9, 2022
Collaborator
|
Feel free to submit once you addressed my remaining comments. |
Collaborator
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenSL ES buffer queue length controls the allocated size of
the internal buffer. So we can use that to make sure there is enough
capacity to protect against glitches when setting a callback size
or a high capacity.
Fixes #744
It might help with #952