Skip to content

unotify: bound retained syscall statistics#290

Open
rndaom wants to merge 1 commit into
google:masterfrom
rndaom:harden/bound-unotify-stats
Open

unotify: bound retained syscall statistics#290
rndaom wants to merge 1 commit into
google:masterfrom
rndaom:harden/bound-unotify-stats

Conversation

@rndaom

@rndaom rndaom commented Jul 22, 2026

Copy link
Copy Markdown

Summary

Bound seccomp-unotify report aggregation retained by the privileged supervisor.

The report path currently retains every distinct syscall record, including sandbox-influenced arguments and resource metadata. Add a bounded StatsStore with conservative entry and accounted-payload limits, checked arithmetic, saturating counters, an omission warning, and focused regression coverage. Existing retained records continue to aggregate after the unique-key limit is reached.

Why

This prevents unbounded supervisor-side telemetry retention when seccomp-unotify reporting receives many distinct sandbox-influenced records. The limits preserve normal reporting while making the retention policy explicit and bounded.

Validation

  • focused unotify/stats_test
  • normal nsjail rebuild
  • focused test under ASan/UBSan and with NDEBUG
  • git diff --check

@google-cla

google-cla Bot commented Jul 22, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant