contain: stop setup if PR_SET_NO_NEW_PRIVS fails#286
Open
srkyn wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot rescan |
srkyn
marked this pull request as ready for review
July 20, 2026 19:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When nsjail is configured to set
no_new_privs, a failedprctl(PR_SET_NO_NEW_PRIVS, 1)call currently produces a warning and lets the jailed command continue.Treat the failed call as an error and stop setup before executing the command. This does not change the explicit
--disable_no_new_privspath.Testing
The full build passes on Ubuntu 24.04 under WSL. Basic true/false execution tests and the seccomp tests also pass.
I used strace syscall injection to force the
PR_SET_NO_NEW_PRIVScall to returnEPERM. nsjail stopped setup and did not execute the jailed command. The same command still ran when invoked with--disable_no_new_privs.The remaining test suite reached the networking tests, then stopped because
pastais not installed.