Repository navigation
fix(about_dialog): Always use black color for window texts - #898
Merged
hiroyuki-komatsu merged 1 commit intoMar 15, 2024
Merged
Conversation
Signed-off-by: Natsuki Ikeguchi <me@s6n.jp>
siketyan
changed the title
Collaborator
|
Hi siketyan, We have been running the internal process to accept your PR. |
Collaborator
|
We have merged your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the QPalette in AboutDialog.app to display texts in black colour even if dark mode is enabled on the environment.
I am really noob of Qt/C++ stack; please let me know if I am missing something to do or doing wrong.
Issue IDs
Closes #897
Steps to test new behaviors (if any)
Additional context
Tested on macOS 14.4 Sonoma, Arm64, M1 Max, Mac Studio (2022).