Repository navigation
Remove legacy LangBar support in Windows - #1599
Merged
Merged
Conversation
hiroyuki-komatsu
left a comment
hiroyuki-komatsu
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for your PR. Here's a comment from an internal reviewer.
In my understanding,
TipLangBaris responsible of
- The classing language bar (floating one, like this -> https://forest.watch.impress.co.jp/article/2001/12/18/xllangbar_1r.html)
- 「あ」「A」and menu in the system taskbar.
And this CL removes the floating language bar support.
If so, we may consider renaming this class.
Collaborator
Author
Ack. Filed #1600 and added a TODO comment. |
This commit removes support for the legacy "Language Bar" in Windows, which is effectively deprecated and rarely used in modern Windows environments, especially since Windows 8 released in 2012. The only observable behavior change is that Mozc's mode icon and tools icon will no longer be displayed on the legacy "Language Bar" when it is explicitly enabled. This is actually the same as how MS-IME Japanese behaves recently. The legacy "Language Bar" itself remains available, and users can still see Mozc's product icon and switch to/from other IMEs. Note that the legacy "Language Bar" cannot be docked into the taskbar. So if the user is seeing IME icons on the taskbar, it means the legacy "Language Bar" is disabled and this commit should have no visible impact for them. One notable benefit of this change is that we can remove 3 colored icons used in Windows client, as colored icons often introduce combinational complexity and maintenance overhead with other features such as high DPI support (google#831) and light/dark theme switching (google#1566). Closes google#1595. See also google#1600 for the renaming renamings.
Collaborator
Author
|
Rebased onto master, to mainly include 54f89a1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit removes support for the legacy "Language Bar" in Windows, which is effectively deprecated and rarely used in modern Windows environments, especially since Windows 8 released in 2012.
The only observable behavior change is that Mozc's mode icon and tools icon will no longer be displayed on the legacy "Language Bar" when it is explicitly enabled. This is actually the same as how MS-IME Japanese behaves recently. The legacy "Language Bar" itself remains available, and users can still see Mozc's product icon and switch to/from other IMEs.
Note that the legacy "Language Bar" cannot be docked into the taskbar. So if the user is seeing IME icons on the taskbar, it means the legacy "Language Bar" is disabled and this commit should have no visible impact for them.
There should be no observable behavior change unless users explicitly enable the legacy "Language Bar" support, which is quite unlikely as even "Language Bar" itself has not received updates for modern features like light/dark theme switching.
Closes #1595.
See also #1600 for the renaming renamings.
Issue IDs
TipLangBarand related classes to something more appropriate #1600Screenshots
Steps to test new behaviors (if any)