Repository navigation
Append and fix entries in symbols.tsv - #1074
Merged
Merged
Conversation
hiroyuki-komatsu
left a comment
hiroyuki-komatsu
left a comment
Collaborator
There was a problem hiding this comment.
Hi tsts-u,
Thank you for your PR!
Please check my comments.
Supports kana input too
Knight is for fortune telling, not for games. https://gamefarm.jp/rule/cego.html https://cardgame.wiki.fc2.com/wiki/%E3%82%BF%E3%83%AD%E3%83%83%E3%83%88%E6%A6%82%E8%AB%96 https://gamefarm.jp/rule/dreierles.html
hiroyuki-komatsu
left a comment
hiroyuki-komatsu
left a comment
Collaborator
There was a problem hiding this comment.
For PRs in future, please refrain from adding the contents in the middle of the review.
Thank you,
Contributor
Author
|
I thought it is a little pain of a neck to switch or merge multiple sets of symbols addition. |
hiroyuki-komatsu
left a comment
hiroyuki-komatsu
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the update. We are almost there.
Collaborator
|
When the PR is updated, I have to run the internal process again from the beginning. So I would like to keep PRs while reviewing. If PRs should be updated, please let us know that. |
Contributor
Author
|
Sorry about that. Now I don't have to append any additional fonts m commits anymore. |
Collaborator
|
We have merged this PR. |
hiroyuki-komatsu
added a commit
that referenced
this pull request
Jan 16, 2025
2.30.5618 → 2.31.5712 Conversion * Updated the LM dictionary * Updated symbols (#1074, #1100) * Updated emoji data to CLDR 46 (Emoji 16.0) * Fixed conversion errors reported by users. Bug fix * Windows: fixed the freeze issue with some applications like the searchhost.exe (#1077, #856) * Windows: fixed the UI language issue of the GUI tools (#1110) Features * Updated the copyright year to 2025. * Windows: bundle debug symbol for Mozc TIP DLL (#1081) * Windows: shutdown existing Mozc processes on upgrading the version (#1093) Build * supported Bazel 8.0.0 (#1118) * removed WORKSPACE support for Bazel (#1115) * supported Python 3.14 (#1084) * updated the protobuf version: v27.3 → v29.1. * Linux: supported gcc-14.1.1 without additional build flags (#927) * macOS / Windows: Updated Qt version: 6.7.3 → 6.8.0 (#1105, #1110, #1121) Code * added a lint checker for BUILD.bazel and *bzl files (#1089) * renamed the protobuf field from Candidates to CandidateWindow * refactoring of ConversionRequest making it as immutable object * refactoring of the Converter implementation * refactoring of Engine and SessionConverter to make each module pluggable * removed cyclic dependency between Converter and Rewriter. PiperOrigin-RevId: 716215275
This was referenced Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue IDs
Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).
"→ Space produces あ゙.(In kana mode) あ → ゛ → Space produces あ゙It's a pain in the buttocks to enumerate all cases in this week. I'll update this in next week.
Additional context
Add any other context about the pull request here.
VS-15 (U+FE0E) is added after Red Dragon and Black Joker.
One or both of Fahrenheit signs can be removed.