Upgrade Rapid YAML to v0.5.0, and switch to the single file amalgamation#1134
Merged
johnbartholomew merged 1 commit intoFeb 27, 2024
Merged
Conversation
johnbartholomew
force-pushed
the
try-rapidyaml-single-file
branch
2 times, most recently
from
403b69a to
46527e0
Compare
This was referenced Feb 9, 2024
Collaborator
Author
|
A few open bugs should be fixed just by upgrading Rapid YAML:
YAML-parsing-related bug #1109 is not fixed by the upgrade and needs other work. |
Rapid YAML has an extensive CMake based build, which is probably ok but might be a pain to use from our other build systems (e.g., Bazel, which we probably want to continue supporting). However, Rapid YAML also provides a single-file amalgamation (aka unity build), which is of course much easier to embed.
johnbartholomew
force-pushed
the
try-rapidyaml-single-file
branch
from
46527e0 to
4003c4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rapid YAML has an extensive CMake based build, which is probably ok but may be awkward to use from our other build systems (e.g., Bazel, which we probably want to continue supporting).
However, Rapid YAML also provides a single-file amalgamation (aka unity build), which is of course much easier to embed.
I expect this makes it harder for users (e.g., distribution packagers) to use a system-provided Rapid YAML install instead. I'd like to fix that, though I'm not sure if anyone is doing that currently - unlike the json lib we don't seem to have prior support for it in the CMake build at least. So it can probably be done as a follow-up. But ideally before the next published release.