Repository navigation
Fix IsSubsetOf failure message to count elements, not matchers - #5130
Open
Huang-404-Q wants to merge 1 commit into
Open
Huang-404-Q wants to merge 1 commit into
Huang-404-Q wants to merge 1 commit into
Conversation
FindPairing reports the closest match for IsSubsetOf as "max_flow of
RhsSize() matchers", but max_flow counts matched elements and the
condition compares against LhsSize(). The Superset branch above correctly
uses RhsSize(); this is a copy-paste error.
For IsSubsetOf({1, 2}) against {1, 1, 1} the message said "1 of 2
matchers"; it now says "1 of 3 elements".
Adds IsSubsetOfTest.MatchAndExplainReportsUnmatchedElementCount.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnorderedElementsAreMatcherImplBase::FindPairingreports the closest match forIsSubsetOfasmax_flow of RhsSize() matchers, butmax_flowcounts matched elements and the condition compares againstLhsSize(). The Superset branch above correctly usesRhsSize(); this is a copy-paste error.For
IsSubsetOf({1, 2})against{1, 1, 1}the message said "1 of 2 matchers"; it now says "1 of 3 elements".Test
Adds
IsSubsetOfTest.MatchAndExplainReportsUnmatchedElementCount.Verified locally: all 11
IsSubsetOfTest.*tests pass. (The fullgmock-matchers-containers_testbinary segfaults atContainsTest.WorksWithMoveOnlyon this MinGW build both before and after the change, so that is a pre-existing environment issue.)AI assistance
Tool(s) used: Claude Code
How you used it: the assistant read the code, wrote the fix and the test, and ran the suite. A human reviewed the diff and takes responsibility for the change.