Repository navigation
Conversation
Expose testing::OsStackTraceGetterInterface in a public header and add UnitTest::set_os_stack_trace_getter(), so users can replace the stack trace getter without defining GTEST_OS_STACK_TRACE_GETTER_ at build time. The interface moves from testing::internal to testing. The setter is not synchronized, so do not call it while another thread may report a failure.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
testing::OsStackTraceGetterInterfacein a public header and addUnitTest::set_os_stack_trace_getter(), allowing users to replace the stack trace getter at runtime instead of definingGTEST_OS_STACK_TRACE_GETTER_at build time.The interface moves from
testing::internaltotesting. The setter is not synchronized, so it must not be called while another thread may report a failure.Fixes #4781