This repository was archived by the owner on Jun 4, 2021. It is now read-only.
Remove invalid proxy behavior of Http and RetryTransport#51
Closed
abergmeier wants to merge 1 commit intogoogle:masterfrom
Closed
Remove invalid proxy behavior of Http and RetryTransport#51abergmeier wants to merge 1 commit intogoogle:masterfrom
abergmeier wants to merge 1 commit intogoogle:masterfrom
Conversation
generates a messed up object because one part of function calls go to self and others delegate to _transport. So only expose methods, which really delegate.
Contributor
|
We don't want to give up the type, but it looks like we want to use the cert functionality, so I'll make the changes. In retrospect, the retry transport's factory should have taken a callable for underlying transports. I think that there aren't so many implementations that we can't proxy calls to underlying transports for add_credentials, add_certificate, clear_credentials, and request. I'll make the internal change for that. |
Author
No problem. But then please make it a real proxy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless we make a proper proxy out of Http and RetryTransport, this generates a messed up object because one part of function calls go to
self and others delegate to _transport.
So only expose methods, which really delegate.