Replace the local clone of quipper with a git submodule of https://github.com/google/perf_data_converter.git, where the original up-to-date version of quipper is open-sourced.#65
Merged
Conversation
…thub.com/google/perf_data_converter.git, where the original version of quipper is open-sourced.
Contributor
Author
|
Removed the dependency to pass the protoc binary path to the --with-protoc flag of ./configure. autofdo will automatically fetch and build protobuf from https://github.com/google/protobuf.git. |
This was referenced Apr 16, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By replacing the existing version of quipper with a submodule, two commits are lost
Note: The bug fixed in the latter commit was introduced in the former commit.
Feel free to update these in the upstream and roll-up the changes to https://github.com/google/perf_data_converter.