Support Safari tab bar mode in EarlGrey openDeepLinkURL. - #2193
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_974101434
branch
from
August 31, 2026 22:20
aae8bdc to
5c2be0d
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_974101434
branch
3 times, most recently
from
September 4, 2026 21:33
a37c2fc to
c2661bd
Compare
copybara-service
Bot
force-pushed
the
test_974101434
branch
from
September 8, 2026 23:14
c2661bd to
5fe2417
Compare
In modern iOS versions (iOS 16+), Safari renders the address bar as a compact tab bar item with accessibility identifier "TabBarItemTitle" (either a text field or a button). Previously, EarlGrey failed to detect the URL bar in this mode, resulting in interaction timeouts. - Add detection and handling for safariApp.textFields[@"TabBarItemTitle"] and safariApp.buttons[@"TabBarItemTitle"] using kWaitForExistenceTimeout. - Tap the element, handle onboarding swipe tutorials on iOS 15+, wait for the URL text field, type the URL, and tap "Go". - Update existing swipeTutorialButton checks in "Search or enter website name" branches to use kWaitForExistenceTimeout instead of the hardcoded 5 seconds. - Add test coverage in DeepLinkTests.g3only.m for opening deep links when Safari has an open tab / tab bar item present. PiperOrigin-RevId: 974101434
copybara-service
Bot
force-pushed
the
test_974101434
branch
from
September 11, 2026 17:57
5fe2417 to
44d2767
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Safari tab bar mode in EarlGrey openDeepLinkURL.
In modern iOS versions (iOS 16+), Safari renders the address bar as a compact
tab bar item with accessibility identifier "TabBarItemTitle" (either a text
field or a button). Previously, EarlGrey failed to detect the URL bar in this
mode, resulting in interaction timeouts.
safariApp.buttons[@"TabBarItemTitle"] using kWaitForExistenceTimeout.
URL text field, type the URL, and tap "Go".
branches to use kWaitForExistenceTimeout instead of the hardcoded 5 seconds.
Safari has an open tab / tab bar item present.