This repository was archived by the owner on Mar 22, 2024. It is now read-only.
Repository navigation
Fix PR #15 : Fix style. Compute rss in mb. Add doc for new stats. - #23
Merged
Merged
Conversation
neuracr
commented
Sep 4, 2019
Contributor
|
Thanks! I think the "non-hang" part of (may need to try a few times, but I pretty frequently get It seems to work until AFL exits (Ctrl-C also seems to break it). Not sure if this is so important, I know AFL_BENCH_UNTIL_CRASH behaves weirdly and doesn't exit immediately anyway. |
| else if (usage.ru_maxrss == 0) { | ||
| fprintf(f, "peak_rss_mb : not available while afl is running\n"); | ||
| } | ||
| else{ |
Contributor
There was a problem hiding this comment.
Please add a space after else, and same comment as above (ie: } else {)
| WARNF("getrusage failed"); | ||
| } | ||
| else if (usage.ru_maxrss == 0){ | ||
| else if (usage.ru_maxrss == 0) { |
Contributor
There was a problem hiding this comment.
let's also do } else if (usage.ru_maxrss == 0) { like the rest of the file, instead of putting else on newline.
…e timeout used is the one defined by the user
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested changes from #15.