Skip to content
This repository was archived by the owner on Mar 22, 2024. It is now read-only.

Implement CMake/packaging support - #11

Closed
alessandrogario wants to merge 6 commits into
google:masterfrom
alessandrogario:alessandro/build/add-cmake-support
Closed

alessandrogario wants to merge 6 commits into
google:masterfrom
alessandrogario:alessandro/build/add-cmake-support

Conversation

@alessandrogario

Copy link
Copy Markdown

This PR implements initial CMake support. Packaging with CPack is also available, and can be triggered with sudo make package

@Dor1s

Dor1s commented Aug 2, 2019

Copy link
Copy Markdown
Contributor

Thanks for the patch! I'm a bit unclear on what's the intention here. Do you want to get rid of Makefile and use CMake instead? Why is it needed, besides the packaging capability?

@alessandrogario

alessandrogario commented Aug 2, 2019 •

Copy link
Copy Markdown
Author

Thanks for the patch! I'm a bit unclear on what's the intention here. Do you want to get rid of Makefile and use CMake instead? Why is it needed, besides the packaging capability?

Hello @Dor1s!

My main goals were:

  1. Add packaging support
  2. Have a CMakeList.txt file that I can open with an IDE (QtCreator, CLion, etc)
  3. Allow projects to add_subdirectory(afl) (where afl is a git submodule pointing here)
  4. Add helpers so that from a CMake project a user can create afl targets

I can close the PR if this does not align with the guidelines/roadmap.

Thanks! 😄

EDIT: Just in case, I still have to add a couple of commits!

@Dor1s

Dor1s commented Aug 5, 2019

Copy link
Copy Markdown
Contributor

@alessandrogario thanks for the clarifications! This definitely makes sense, but I'd rather hold on for some time and consider doing this later as a planned effort (e.g. maybe with or after some other refactoring / code structure changes).

I'm sorry for rejecting this PR right now, but let me open an issue for CMake support and mention this as a starting point. Hopefully we (and/or you) can get back to this later :)

@Dor1s Dor1s closed this Aug 5, 2019
@alessandrogario
alessandrogario deleted the alessandro/build/add-cmake-support branch August 5, 2019 20:58
@Dor1s Dor1s mentioned this pull request Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants