fix(release): handle npm dist-tag deletion failures on registries that forbid it - #28694
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses intermittent failures in the nightly release pipeline caused by npm registries that prohibit the deletion of dist-tags. By modifying the release action to catch and log errors during the staging-tmp tag removal process, the pipeline can now proceed successfully even when specific registry security policies prevent tag cleanup. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/S
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the release publishing GitHub action to gracefully handle failures when removing the temporary staging tag (staging-tmp). Specifically, it appends || echo ... to the npm dist-tag rm commands for the core, CLI, and agent-to-agent packages, preventing workflow failures on registries that forbid tag deletion (such as Wombat). It also fixes the indentation of the conditional block for the agent-to-agent package release step. There are no review comments, and I have no feedback to provide.
|
Size Change: -4 B (0%) Total Size: 35.2 MB
ℹ️ View Unchanged
|
gemini-cli
Bot
added
priority/p1
2 participants
Summary
This PR handles npm
dist-tagdeletion failures on npm registries that forbid tag deletion (like Wombat Dressing Room, which returns403 Forbidden).Details
During nightly release runs, the target registry fallback is configured to Wombat Dressing Room (
https://wombat-dressing-room.appspot.com). Since Wombat blocks HTTPDELETEoperations on tags for security reasons, thenpm dist-tag rmstep failed and halted the nightly builds.By appending
|| echo "Warning: ..."to each of the threenpm dist-tag rm ... staging-tmpsteps in.github/actions/publish-release/action.yml, we gracefully handle these failures. The staging/release flow remains fully functional because:staging-tmpis only a temporary staging marker to preventnpmfrom automatically applying thelatesttag prematurely.npm dist-tag addduring the subsequenttag-npm-releasestep.This is a robust and registry-agnostic solution that logs a warning and allows the release pipeline to proceed on registries where tag deletion is disabled.
Related Issues
Resolves the nightly release pipeline failures that began after Commit
d3ef6aca40c5(PR #28104) changed the default registry fallback.How to Validate
npm run lintandnpm run typechecklocally to confirm no regressions.Pre-Merge Checklist