Avoid persisting empty resume sessions#27770
Merged
Merged
Conversation
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves session management by ensuring that only meaningful conversations are persisted and surfaced in the UI. By defining what constitutes 'resumable content'—specifically excluding command-only or system-generated messages—the system now avoids cluttering the session history with empty or trivial startup artifacts. This change includes robust cleanup logic to discard abandoned sessions upon exit and updates existing listing utilities to respect these new filtering criteria. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
📊 PR Size: size/L
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces logic to identify and clean up non-resumable sessions (such as startup-only, command-only, or internal-context-only sessions) to prevent them from cluttering the session history. It adds filtering helpers, registers a cleanup task in the interactive CLI, and includes comprehensive unit tests. The review feedback highlights two critical issues: first, the cleanup function is removed from the registry during normal exit without being executed, which prevents session cleanup on clean exits; second, message.content lacks a safety guard, which could lead to a runtime TypeError and crash the CLI when processing malformed or legacy records.
|
Size Change: +2.01 kB (+0.01%) Total Size: 33.9 MB
ℹ️ View Unchanged
|
gemini-cli
Bot
added
the
area/unknown
galz10
reviewed
Jun 9, 2026
galz10
left a comment
galz10
left a comment
Collaborator
There was a problem hiding this comment.
Code Review
Intent Summary: Avoid persisting and listing interactive sessions that contain only commands (e.g., /resume) or system contexts without any real conversational content (user text or model responses).
🧹 Refactoring & Nits (P2/P3)
Recommended improvements.
packages/cli/src/utils/sessionUtils.ts&packages/cli/src/utils/sessionUtils.test.ts: The newly addedhasResumableContentwrapper function is exported but never actually used in the codebase (getAllSessionFilesnow correctly consumes thehasResumableContentboolean property directly from the parsed backend object). Remove this wrapper function entirely and move its extensive test cases directly intopackages/core/src/services/chatRecordingService.test.tsto test the actual backend implementation.packages/core/src/services/chatRecordingService.ts:102: TheisIgnoredUserContentfunction duplicates the exact skip-prefix rules (startsWith('/'),startsWith('<session_context>'), etc.) already hardcoded inpackages/core/src/utils/sessionUtils.ts. Extract this into a shared utility function inpackages/core/src/utils/sessionUtils.tsto ensure skip-rules remain in sync.packages/cli/src/utils/sessionUtils.tsandpackages/core/src/services/chatRecordingService.ts: ThehasUserOrAssistantMessageutility function, its tests, and its corresponding property on theloadConversationRecordreturn type are now dead code sincegetAllSessionFileshas fully migrated tohasResumableContent. Remove them.
📝 Metadata Review
Feedback on PR description or commit message clarity.
- The PR description is extremely clear, links to the relevant issue, and provides concrete, platform-specific validation steps. Excellent work detailing the intent and testing strategy.
galz10
approved these changes
Jun 9, 2026
This was referenced Jun 10, 2026
teknium1
added a commit
to NousResearch/hermes-agent
that referenced
this pull request
Jun 11, 2026
Port from google-gemini/gemini-cli#27770: starting the CLI and immediately quitting (or rotating with /new, /clear) left an empty untitled session row behind. These ghost rows pile up in /resume, `hermes sessions list`, and the in-chat recent-sessions browser. - SessionDB.delete_session_if_empty(): transactional check-and-delete that only removes rows with no messages, no title, and no child sessions (delegate subagent parents are preserved). Also removes on-disk transcript files via the existing _remove_session_files. - HermesCLI._discard_session_if_empty(): thin wrapper, wired into the cli_close shutdown path and the new_session() rotation path. Skipped when /exit --delete already handles removal. Unlike the one-shot prune_empty_ghost_sessions migration (TUI-only, 24h-old rows), this prevents new ghost rows from accumulating at the moment they would be created.
goingforstudying-ctrl
pushed a commit
to goingforstudying-ctrl/hermes-agent
that referenced
this pull request
Jun 11, 2026
Port from google-gemini/gemini-cli#27770: starting the CLI and immediately quitting (or rotating with /new, /clear) left an empty untitled session row behind. These ghost rows pile up in /resume, `hermes sessions list`, and the in-chat recent-sessions browser. - SessionDB.delete_session_if_empty(): transactional check-and-delete that only removes rows with no messages, no title, and no child sessions (delegate subagent parents are preserved). Also removes on-disk transcript files via the existing _remove_session_files. - HermesCLI._discard_session_if_empty(): thin wrapper, wired into the cli_close shutdown path and the new_session() rotation path. Skipped when /exit --delete already handles removal. Unlike the one-shot prune_empty_ghost_sessions migration (TUI-only, 24h-old rows), this prevents new ghost rows from accumulating at the moment they would be created.
alt-glitch
pushed a commit
to NousResearch/hermes-agent
that referenced
this pull request
Jun 14, 2026
Port from google-gemini/gemini-cli#27770: starting the CLI and immediately quitting (or rotating with /new, /clear) left an empty untitled session row behind. These ghost rows pile up in /resume, `hermes sessions list`, and the in-chat recent-sessions browser. - SessionDB.delete_session_if_empty(): transactional check-and-delete that only removes rows with no messages, no title, and no child sessions (delegate subagent parents are preserved). Also removes on-disk transcript files via the existing _remove_session_files. - HermesCLI._discard_session_if_empty(): thin wrapper, wired into the cli_close shutdown path and the new_session() rotation path. Skipped when /exit --delete already handles removal. Unlike the one-shot prune_empty_ghost_sessions migration (TUI-only, 24h-old rows), this prevents new ghost rows from accumulating at the moment they would be created.
AIalliAI
pushed a commit
to AIalliAI/Hermes
that referenced
this pull request
Jun 14, 2026
Port from google-gemini/gemini-cli#27770: starting the CLI and immediately quitting (or rotating with /new, /clear) left an empty untitled session row behind. These ghost rows pile up in /resume, `hermes sessions list`, and the in-chat recent-sessions browser. - SessionDB.delete_session_if_empty(): transactional check-and-delete that only removes rows with no messages, no title, and no child sessions (delegate subagent parents are preserved). Also removes on-disk transcript files via the existing _remove_session_files. - HermesCLI._discard_session_if_empty(): thin wrapper, wired into the cli_close shutdown path and the new_session() rotation path. Skipped when /exit --delete already handles removal. Unlike the one-shot prune_empty_ghost_sessions migration (TUI-only, 24h-old rows), this prevents new ghost rows from accumulating at the moment they would be created.
davidgut1982
pushed a commit
to davidgut1982/hermes-agent
that referenced
this pull request
Jun 17, 2026
Port from google-gemini/gemini-cli#27770: starting the CLI and immediately quitting (or rotating with /new, /clear) left an empty untitled session row behind. These ghost rows pile up in /resume, `hermes sessions list`, and the in-chat recent-sessions browser. - SessionDB.delete_session_if_empty(): transactional check-and-delete that only removes rows with no messages, no title, and no child sessions (delegate subagent parents are preserved). Also removes on-disk transcript files via the existing _remove_session_files. - HermesCLI._discard_session_if_empty(): thin wrapper, wired into the cli_close shutdown path and the new_session() rotation path. Skipped when /exit --delete already handles removal. Unlike the one-shot prune_empty_ghost_sessions migration (TUI-only, 24h-old rows), this prevents new ghost rows from accumulating at the moment they would be created.
T02200059
pushed a commit
to T02200059/hermes-agent
that referenced
this pull request
Jun 18, 2026
Port from google-gemini/gemini-cli#27770: starting the CLI and immediately quitting (or rotating with /new, /clear) left an empty untitled session row behind. These ghost rows pile up in /resume, `hermes sessions list`, and the in-chat recent-sessions browser. - SessionDB.delete_session_if_empty(): transactional check-and-delete that only removes rows with no messages, no title, and no child sessions (delegate subagent parents are preserved). Also removes on-disk transcript files via the existing _remove_session_files. - HermesCLI._discard_session_if_empty(): thin wrapper, wired into the cli_close shutdown path and the new_session() rotation path. Skipped when /exit --delete already handles removal. Unlike the one-shot prune_empty_ghost_sessions migration (TUI-only, 24h-old rows), this prevents new ghost rows from accumulating at the moment they would be created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid surfacing empty or command-only sessions in resume flows, and clean up startup-only interactive sessions on exit so immediately-started-and-quit sessions are not persisted.
Details
Related Issues
Related to #18007
How to Validate
Pre-Merge Checklist