feat(cli): add [Skill] tag to slash command autocomplete suggestions#27440
feat(cli): add [Skill] tag to slash command autocomplete suggestions#27440Hariharanpugazh wants to merge 1 commit into
Conversation
Adds a [Skill] suffix to skill-backed slash commands in the autocomplete suggestion menu, mirroring the existing [MCP] and [Agent] tags. Makes it easy to distinguish skills from built-in commands at a glance. Refs google-gemini#21165
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a visual improvement to the CLI slash command autocomplete menu. By adding a [Skill] suffix to skill-backed commands, it aligns the UI with existing patterns used for MCP prompts and agents, making it easier for users to identify the source of available commands. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request adds support for displaying a [Skill] tag next to skill commands in the suggestions UI. It updates the COMMAND_KIND_SUFFIX mapping in SuggestionsDisplay.tsx, adds a corresponding unit test in SuggestionsDisplay.test.tsx, and updates the test snapshots. I have no feedback to provide as there are no review comments to address.
|
@googlebot I signed it! |
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
|
This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding. |
Summary
Adds a
[Skill]tag to skill-backed slash commands in the/autocomplete menu, mirroring the existing[MCP]and[Agent]visual treatment. Makes it immediately obvious which entries in the menu are user-installed skills vs. built-in commands.Before:
After:
Context
The original feature request asked for two things:
/skill-name/autocomplete menu (with descriptions)While digging into the codebase I found that both behaviors were already implemented by
SkillCommandLoader(introduced in #21758, with follow-ups in #21942 and #25327). Skills already appear in the menu and/skill-namealready activates them via the existingactivate_skilltool.What was missing was the small but useful visual cue: skills had no
[Skill]suffix in the suggestion list, unlike MCP prompts ([MCP]) and agents ([Agent]), so they were visually indistinguishable from built-in commands. This PR closes that gap.If maintainers agree the issue is otherwise complete, this PR can be the final piece before closing #21165.
Changes
packages/cli/src/ui/components/SuggestionsDisplay.tsx— add[CommandKind.SKILL]: ' [Skill]'to theCOMMAND_KIND_SUFFIXmap.packages/cli/src/ui/components/SuggestionsDisplay.test.tsx— new snapshot test mirroring the existing[MCP]test.packages/cli/src/ui/components/__snapshots__/SuggestionsDisplay.test.tsx.snap— generated snapshot for the new test.Net change: +30 lines, 1 line of production logic.
Testing
SkillCommandLoadertests still pass.eslintclean on the modified files.tsc --noEmitclean for the cli package.Related
Refs #21165