Skip to content

fix(core): resolve EISDIR errors during file processing (#21527) #27041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scidomino merged 5 commits into from
May 14, 2026
Merged

fix(core): resolve EISDIR errors during file processing (#21527) #27041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
35cbd3b
fix(core): resolve EISDIR errors during file processing (#21527)
ProthamD May 14, 2026
a78b047
Merge branch 'main' into fix/eisdir-stat-check
ProthamD May 14, 2026
7723cde
refactor(core): optimize isBinaryFile redundant stat calls based on r…
ProthamD May 14, 2026
e0cb2b7
refactor(core): remove resolveToRealPath and use !isFile() based on m…
ProthamD May 14, 2026
5b75511
Merge branch 'main' into fix/eisdir-stat-check
ProthamD May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/src/tools/read-many-files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ ${finalExclusionPatternsForDescription
const fullPath = path.join(dir, normalizedP);
let exists = false;
try {
await fsPromises.access(fullPath);
exists = true;
const st = await fsPromises.stat(fullPath);
exists = st.isFile();
} catch {
exists = false;
}
Expand Down
5 changes: 4 additions & 1 deletion packages/core/src/utils/fileUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { ToolErrorType } from '../tools/tool-error.js';
import { BINARY_EXTENSIONS } from './ignorePatterns.js';
import { createRequire as createModuleRequire } from 'node:module';
import { debugLogger } from './debugLogger.js';

import {
DEFAULT_MAX_LINES_TEXT_FILE,
MAX_LINE_LENGTH_TEXT_FILE,
Expand Down Expand Up @@ -350,7 +351,9 @@ export async function isEmpty(filePath: string): Promise<boolean> {
*/
export async function isBinaryFile(filePath: string): Promise<boolean> {
try {
return await isBinaryFileCheck(filePath);
const stats = await fsPromises.stat(filePath);
if (!stats.isFile()) return false;
return await isBinaryFileCheck(filePath, stats.size);
} catch (error) {
debugLogger.warn(
`Failed to check if file is binary: ${filePath}`,
Expand Down
Loading