Skip to content

fix(core): disable retries for code assist streaming requests#20561

Merged
sehoon38 merged 3 commits into
mainfrom
fix-ca-streaming-retries
Feb 27, 2026
Merged

fix(core): disable retries for code assist streaming requests#20561
sehoon38 merged 3 commits into
mainfrom
fix-ca-streaming-retries

Conversation

@sehoon38

@sehoon38 sehoon38 commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR disables retries for Code Assist streaming requests, as we are doing retries in two places.
By setting retry: false in requestStreamingPost within server.ts, we ensure that streaming operations (like streamGenerateContent) do not perform automatic retries, as we also have our retries logic in retry.ts with more robust retry logic that has exponential backoffs and UI integration.
Also increase the delay for generateContent to 1000 ms from 100 ms (Gaxios retry default = 100ms) for other non-streaming model calls.

Details

  • Modified packages/core/src/code_assist/server.ts: Added retry: false to the client.request options in requestStreamingPost.

Related Issues

Fixes #20560

How to Validate

  1. Trigger a Code Assist streaming request (e.g., via generateContentStream).
  2. Simulate a network failure or a non-terminal error status that would normally trigger a retry.
  3. Verify that the request fails immediately without attempting a retry.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run

@sehoon38 sehoon38 requested a review from a team as a code owner February 27, 2026 14:07
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where automatic retries for Code Assist streaming requests could lead to corrupted data streams or redundant responses. By explicitly disabling retries for these specific operations, the change ensures a more reliable and consistent user experience for features relying on real-time content generation.

Highlights

  • Code Assist Streaming Retries: Disabled automatic retries for Code Assist streaming requests to ensure stream integrity and prevent duplicate partial responses.
Changelog
  • packages/core/src/code_assist/server.ts
    • Disabled retries for streaming POST requests by adding "retry: false" to the request options.
Activity
  • The pull request author has validated the changes on MacOS using "npm run".
  • The author has confirmed that documentation and tests were not needed for this change.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

github-actions Bot commented Feb 27, 2026

Copy link
Copy Markdown

Size Change: -51 B (0%)

Total Size: 25.7 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.2 MB -51 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request modifies packages/core/src/code_assist/server.ts to add retry: false to the fetch options in the CodeAssistServer class.

@gemini-cli gemini-cli Bot added the area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality label Feb 27, 2026
@sehoon38 sehoon38 force-pushed the fix-ca-streaming-retries branch from a13c690 to 7119e31 Compare February 27, 2026 17:17
@sehoon38 sehoon38 force-pushed the fix-ca-streaming-retries branch from 7119e31 to f8cdc8e Compare February 27, 2026 17:17
@sehoon38 sehoon38 enabled auto-merge February 27, 2026 17:55
@sehoon38 sehoon38 added this pull request to the merge queue Feb 27, 2026
Merged via the queue into main with commit fdd844b Feb 27, 2026
27 checks passed
@sehoon38 sehoon38 deleted the fix-ca-streaming-retries branch February 27, 2026 18:17
BryanBradfo pushed a commit to BryanBradfo/gemini-cli that referenced this pull request Mar 5, 2026
warrenzhu25 pushed a commit to warrenzhu25/gemini-cli that referenced this pull request Apr 9, 2026
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable retries for Code Assist streaming requests

3 participants