fix(cli): keep thought summary when loading phrases are off

[LyalinDotCom]

Summary

Fixes a regression where setting ui.loadingPhrases=off also hid model thought summaries in the loading row.

Problem

Composer suppressed thought whenever loading phrases were off, which incorrectly removed thinking summaries during normal Responding state.

Changes

• Updated both LoadingIndicator call sites in Composer to suppress thought only for StreamingState.WaitingForConfirmation.
• Kept currentLoadingPhrase suppression for ui.loadingPhrases=off unchanged.
• Updated Composer test coverage to assert thought text remains visible when loading phrases are off.

Validation

• npm test -w @google/gemini-cli -- src/ui/components/Composer.test.tsx src/ui/components/LoadingIndicator.test.tsx src/ui/hooks/useGeminiStream.test.tsx src/ui/hooks/useLoadingIndicator.test.tsx
• npm run lint --workspace=@google/gemini-cli
• npm run typecheck --workspace=@google/gemini-cli

Fixes #20496

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a regression that caused thought summaries to be unintentionally hidden when the ui.loadingPhrases setting was turned off. The changes ensure that thought summaries are displayed correctly during the Responding state, providing a more consistent user experience by only suppressing them when the system is explicitly waiting for user confirmation.

Highlights

• Bug Fix: Resolved a regression where disabling ui.loadingPhrases incorrectly hid model thought summaries, even during active Responding states.
• Logic Update: Modified the Composer component to ensure thought summaries are only suppressed when the StreamingState is WaitingForConfirmation, not when ui.loadingPhrases is off.
• Test Coverage: Updated existing tests and added new assertions to verify that thought text remains visible when loading phrases are disabled, confirming the fix.

Changelog

• packages/cli/src/ui/components/Composer.test.tsx
  • Updated test description to reflect that LoadingIndicator should render with thought when loading phrases are off.
  • Modified assertion to expect the LoadingIndicator to contain the thought text, validating the fix.
• packages/cli/src/ui/components/Composer.tsx
  • Removed the condition settings.merged.ui.loadingPhrases === 'off' from the thought prop logic for LoadingIndicator components.
  • Ensured thought is only undefined when uiState.streamingState is StreamingState.WaitingForConfirmation.

Activity

• The pull request author, LyalinDotCom, created this PR to fix a regression identified in issue ui.loadingPhrases=off hides thinking summary while responding #20496.
• The author provided a detailed summary, problem description, changes, and validation steps in the PR body.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a regression where disabling loading phrases also incorrectly hid the model's thought summaries. The changes in Composer.tsx correctly separate the logic for displaying thoughts from the loading phrases setting, ensuring thought summaries remain visible as intended. The fix is applied consistently to both instances of the LoadingIndicator. The test updates in Composer.test.tsx are also appropriate, confirming the corrected behavior.

[github-actions]

Size Change: -96 B (0%)

Total Size: 25.7 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	25.2 MB	-96 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js	221 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js	227 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js	11.5 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js	132 B	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}

[jacob314]