Skip to content

feat(core): introduce Kind.Agent for sub-agent classification#20369

Merged
abhipatel12 merged 1 commit into
mainfrom
abhi/parallel-agents
Feb 26, 2026
Merged

feat(core): introduce Kind.Agent for sub-agent classification#20369
abhipatel12 merged 1 commit into
mainfrom
abhi/parallel-agents

Conversation

@abhipatel12

Copy link
Copy Markdown
Contributor

Summary

This PR introduces a new tool category, Kind.Agent, to distinguish sub-agents from generic "Thinking" tools. This is the foundational step for enabling parallel execution of sub-agents by signaling to the Scheduler that they are independent agent loops.

Details

  • Added Kind.Agent = 'agent' to the Kind enum in packages/core/src/tools/tools.ts.
  • Updated SubagentTool and SubagentToolWrapper to use Kind.Agent.
  • Updated Zed integration in packages/cli/src/zed-integration/zedIntegration.ts to map Kind.Agent to 'think', maintaining compatibility with the ACP protocol while resolving type/ESLint issues.
  • Added test coverage for the new classification in SubagentTool.

Related Issues

Part of the Parallel Sub-Agent Execution initiative.

How to Validate

  1. Run unit tests for core package: npm test -w @google/gemini-cli-core -- src/agents/subagent-tool.test.ts
  2. Run unit tests for subagent-tool-wrapper: npm test -w @google/gemini-cli-core -- src/agents/subagent-tool-wrapper.test.ts
  3. Verify type safety: npm run typecheck -w @google/gemini-cli
  4. Verify Zed integration mapping: Run npm run lint -w @google/gemini-cli and ensure no unsafe type assertion errors in zedIntegration.ts.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@abhipatel12 abhipatel12 requested a review from a team as a code owner February 25, 2026 23:53
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @abhipatel12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes a new classification for sub-agents within the system by introducing a dedicated Kind.Agent enum. This change is a foundational step towards enabling parallel execution of sub-agents by providing a clear signal to the Scheduler that these are independent agent loops, improving system architecture and future scalability.

Highlights

  • New Tool Classification: Introduced a new Kind.Agent enum value to distinctly classify sub-agents within the system.
  • Sub-Agent Tool Updates: Updated SubagentTool and SubagentToolWrapper to utilize the new Kind.Agent for proper classification, replacing the previous Kind.Think.
  • Zed Integration Compatibility: Modified Zed integration to map the new Kind.Agent to the existing 'think' ACP protocol kind, ensuring backward compatibility.
  • Test Coverage: Added a new unit test to confirm that SubagentTool correctly uses the Kind.Agent classification.
Changelog
  • packages/cli/src/zed-integration/zedIntegration.ts
    • Mapped the new Kind.Agent to the acp.ToolKind.Think for Zed integration.
  • packages/core/src/agents/subagent-tool-wrapper.test.ts
    • Updated the test assertion for SubagentToolWrapper to expect Kind.Agent.
  • packages/core/src/agents/subagent-tool-wrapper.ts
    • Modified the SubagentToolWrapper constructor to use Kind.Agent instead of Kind.Think.
  • packages/core/src/agents/subagent-tool.test.ts
    • Added an import for Kind.
    • Added a new test case to verify that SubagentTool's kind property is set to Kind.Agent.
  • packages/core/src/agents/subagent-tool.ts
    • Updated the SubagentTool constructor to assign Kind.Agent as its type.
  • packages/core/src/tools/tools.ts
    • Extended the Kind enum with a new member, Agent = 'agent'.
Activity
  • No specific review comments or approvals have been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Kind.Agent as a new tool category to classify sub-agents, replacing the more generic Kind.Think. The changes are applied to SubagentTool and SubagentToolWrapper. For compatibility with the ACP protocol, Kind.Agent is mapped to 'think' in the Zed integration. Tests have been updated to reflect these changes. The modifications are consistent with the goal of distinguishing sub-agent tools, which is a prerequisite for future work on parallel execution.

@gemini-cli gemini-cli Bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 25, 2026
@github-actions

Copy link
Copy Markdown

Size Change: +82 B (0%)

Total Size: 25.7 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.2 MB +82 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@abhipatel12 abhipatel12 added this pull request to the merge queue Feb 26, 2026
Merged via the queue into main with commit 28c9a90 Feb 26, 2026
30 checks passed
@abhipatel12 abhipatel12 deleted the abhi/parallel-agents branch February 26, 2026 01:16
BryanBradfo pushed a commit to BryanBradfo/gemini-cli that referenced this pull request Mar 5, 2026
warrenzhu25 pushed a commit to warrenzhu25/gemini-cli that referenced this pull request Apr 9, 2026
@sripasg sripasg added the size/s A small PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s A small PR status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants