feat(core): introduce Kind.Agent for sub-agent classification#20369
Conversation
Summary of ChangesHello @abhipatel12, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a new classification for sub-agents within the system by introducing a dedicated Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces Kind.Agent as a new tool category to classify sub-agents, replacing the more generic Kind.Think. The changes are applied to SubagentTool and SubagentToolWrapper. For compatibility with the ACP protocol, Kind.Agent is mapped to 'think' in the Zed integration. Tests have been updated to reflect these changes. The modifications are consistent with the goal of distinguishing sub-agent tools, which is a prerequisite for future work on parallel execution.
|
Size Change: +82 B (0%) Total Size: 25.7 MB ℹ️ View Unchanged
|
Summary
This PR introduces a new tool category,
Kind.Agent, to distinguish sub-agents from generic "Thinking" tools. This is the foundational step for enabling parallel execution of sub-agents by signaling to theSchedulerthat they are independent agent loops.Details
Kind.Agent = 'agent'to theKindenum inpackages/core/src/tools/tools.ts.SubagentToolandSubagentToolWrapperto useKind.Agent.packages/cli/src/zed-integration/zedIntegration.tsto mapKind.Agentto'think', maintaining compatibility with the ACP protocol while resolving type/ESLint issues.SubagentTool.Related Issues
Part of the Parallel Sub-Agent Execution initiative.
How to Validate
npm test -w @google/gemini-cli-core -- src/agents/subagent-tool.test.tsnpm test -w @google/gemini-cli-core -- src/agents/subagent-tool-wrapper.test.tsnpm run typecheck -w @google/gemini-clinpm run lint -w @google/gemini-cliand ensure no unsafe type assertion errors inzedIntegration.ts.Pre-Merge Checklist