Refactor common settings logic for hooks, skills, and agents

[sehoon38]

Description

There is significant code duplication between hookSettings.ts, skillSettings.ts, and agentSettings.ts in packages/cli/src/utils/.

All three files implement similar logic for:

• Enabling/disabling features (hooks, skills, agents).
• Iterating over writable scopes (User, Workspace).
• Checking existing states and modifying settings.
• Defining result interfaces (HookActionResult, SkillActionResult, AgentActionResult) that share a common structure.

Additionally, ModifiedScope is currently defined in skillSettings.ts and imported by the others, which creates an implicit dependency.

Proposed Solution

Extract the common logic into a generic utility (e.g., packages/cli/src/utils/featureToggleUtils.ts or similar).

This utility should handle:

• The generic flow of checking scopes and updating settings.
• A shared FeatureActionResult interface.
• ModifiedScope definition.

Acceptance Criteria

1. Create a shared utility for feature toggling.
2. Refactor hookSettings.ts, skillSettings.ts, and agentSettings.ts to use this shared utility.
3. Ensure all existing tests pass.

[gemini-cli]

Found possible duplicate issues:

• Refactor: Unify enable/disable feedback logic for Agents, Hooks, and Skills #16823

If you believe this is not a duplicate, please remove the status/possible-duplicate label.

[ishaanxgupta]

/assign

[gemini-cli]

👋 @ishaanxgupta, you've been assigned to this issue! Thank you for taking the time to contribute. Make sure to check out our contributing guidelines.

[ishaanxgupta]

@sehoon38 i did not find hooksettings.ts, I think it got refactored or something. also should I add test files for skills and agents, they were not present